commit 84cc90f63ac1f1604572da25bff694b9262a5312
author Waleed Elmelegy <waleed.elmelegy@arm.com> Wed Nov 27 15:44:53 2024 +0000
committer Waleed Elmelegy <waleed.elmelegy@arm.com> Wed Nov 27 16:08:01 2024 +0000
tree 23ea8e5b80993acc0fdfe90287daad38f638e578
parent b30233f6c374c22e9b6b060ec2ee594308f5da8a

Improve parameter checking in psa_export_public_key_iop_setup()

Signed-off-by: Waleed Elmelegy <waleed.elmelegy@arm.com>

tf-psa-crypto/core/psa_crypto.c

diff --git a/tf-psa-crypto/core/psa_crypto.c b/tf-psa-crypto/core/psa_crypto.c
index 038bd98..827a228 100644
--- a/tf-psa-crypto/core/psa_crypto.c
+++ b/tf-psa-crypto/core/psa_crypto.c
@@ -1714,18 +1714,23 @@
     }
 
     private_key_attributes = slot->attr;
-    if (status != PSA_SUCCESS) {
+
+    private_key_type = psa_get_key_type(&private_key_attributes);
+
+    if (!PSA_KEY_TYPE_IS_KEY_PAIR(private_key_type)) {
+        status = PSA_ERROR_INVALID_ARGUMENT;
         goto exit;
     }
 
-    private_key_type = psa_get_key_type(&private_key_attributes);
     if (!PSA_KEY_TYPE_IS_ECC_KEY_PAIR(private_key_type)) {
+        status = PSA_ERROR_NOT_SUPPORTED;
         goto exit;
     }
 
     key_size = PSA_EXPORT_KEY_OUTPUT_SIZE(private_key_type,
                                           psa_get_key_bits(&private_key_attributes));
     if (key_size == 0) {
+        status = PSA_ERROR_INVALID_ARGUMENT;
         goto exit;
     }