commit 86c5c61a91e08a3b2ed6d8be326f314726b65712
author Jonas <jonas.lejeune4420@gmail.com> Fri May 08 16:57:18 2020 +0900
committer Gilles Peskine <Gilles.Peskine@arm.com> Mon May 25 13:56:48 2020 +0200
tree 94ddf67db71a1d4a73cbf0a3c4ae97c97038f1e7
parent 087bb4c5b158578ae0bb8e02c0b53b15e1ff5d9c

Fix potential memory leak in EC multiplication

Signed-off-by: Jonas <jonas.lejeune4420@gmail.com>

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 108695b..d48e3e8 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1134,7 +1134,10 @@
             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
 
         if( count++ > 10 )
-            return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
+        {
+            ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+            goto cleanup;
+        }
     }
     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );
 
@@ -1552,7 +1555,10 @@
             MBEDTLS_MPI_CHK( mbedtls_mpi_shift_r( &l, 1 ) );
 
         if( count++ > 10 )
-            return( MBEDTLS_ERR_ECP_RANDOM_FAILED );
+        {
+            ret = MBEDTLS_ERR_ECP_RANDOM_FAILED;
+            goto cleanup;
+        }
     }
     while( mbedtls_mpi_cmp_int( &l, 1 ) <= 0 );