commit 87c96c2e53023d9aeeaeb8257ca66e01fe64ab6f
author Jonathan Leroy <jonathan@inikup.com> Wed Oct 14 09:41:56 2015 +0200
committer Jonathan Leroy <jonathan@inikup.com> Wed Oct 14 09:41:56 2015 +0200
tree 618fd9d00d57d1e155e92768213abee65f79cfbf
parent d97f899f99e15fa058ade6d6d8ecf2bbcce74aee

Fix boolean values according to DER specs

In BER encoding, any boolean with a non-zero value is considered as
TRUE. However, DER encoding require a value of 255 (0xFF) for TRUE.

This commit makes `mbedtls_asn1_write_bool` function uses `255` instead
of `1` for BOOLEAN values.

With this fix, boolean values are now reconized by OS X keychain (tested
on OS X 10.11).

Fixes #318.

library/asn1write.c

diff --git a/library/asn1write.c b/library/asn1write.c
index dd5a745..849e8c1 100644
--- a/library/asn1write.c
+++ b/library/asn1write.c
@@ -191,7 +191,7 @@
     if( *p - start < 1 )
         return( MBEDTLS_ERR_ASN1_BUF_TOO_SMALL );
 
-    *--(*p) = (boolean) ? 1 : 0;
+    *--(*p) = (boolean) ? 255 : 0;
     len++;
 
     MBEDTLS_ASN1_CHK_ADD( len, mbedtls_asn1_write_len( p, start, len ) );