tree c5ef3d2c9ecb1e878c9a68d9da99fe8e66b7a2de
parent 7ba73e575618c8bb8f03b544b322768335db9de7
author Gilles Peskine <Gilles.Peskine@arm.com> 1612008332 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> 1614019241 +0100

Fix mutex leak in CTR_DRBG

mbedtls_ctr_drbg_free() left a mutex in the initialized state. This
caused a resource leak on platforms where mbedtls_mutex_init()
allocates resources.

To fix this, mbedtls_ctr_drbg_free() no longer reinitializes the
mutex. To preserve the property that mbedtls_ctr_drbg_free() leaves
the object in an initialized state, which is generally true throughout
the library except regarding mutex objects on some platforms, no
longer initialize the mutex in mbedtls_ctr_drbg_init(). Since the
mutex is only used after seeding, and seeding is only permitted once,
call mbedtls_mutex_init() as part of the seeding process.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>