commit 8b0908aaa73ea661ff7f6968e9a18ab5b14f3800
author Tom Cosgrove <tom.cosgrove@arm.com> Mon Aug 19 15:50:37 2024 +0100
committer GitHub <noreply@github.com> Mon Aug 19 15:50:37 2024 +0100
tree 5a06e8a222a7dadea180ab2a45212a911bd1790c
parent 1782cc8b95239f7fe64bd108c3921961b035fcfe
parent 2547cd353565d906175a0b2a34071a81ebf80729

Merge pull request #1270 from sezrab/memory_allocation_cleanup_psa_crypto_rsa-development

Fix: Memory allocation cleanup in internal crypto api functions

tf-psa-crypto/core/psa_crypto_rsa.c

diff --git a/tf-psa-crypto/core/psa_crypto_rsa.c b/tf-psa-crypto/core/psa_crypto_rsa.c
index f8e36d8..5fe26ec 100644
--- a/tf-psa-crypto/core/psa_crypto_rsa.c
+++ b/tf-psa-crypto/core/psa_crypto_rsa.c
@@ -197,16 +197,13 @@
 
     status = mbedtls_psa_rsa_load_representation(
         attributes->type, key_buffer, key_buffer_size, &rsa);
-    if (status != PSA_SUCCESS) {
-        return status;
+    if (status == PSA_SUCCESS) {
+        status = mbedtls_psa_rsa_export_key(PSA_KEY_TYPE_RSA_PUBLIC_KEY,
+                                            rsa,
+                                            data,
+                                            data_size,
+                                            data_length);
     }
-
-    status = mbedtls_psa_rsa_export_key(PSA_KEY_TYPE_RSA_PUBLIC_KEY,
-                                        rsa,
-                                        data,
-                                        data_size,
-                                        data_length);
-
     mbedtls_rsa_free(rsa);
     mbedtls_free(rsa);
 
@@ -264,6 +261,7 @@
                               (unsigned int) attributes->bits,
                               exponent);
     if (ret != 0) {
+        mbedtls_rsa_free(&rsa);
         return mbedtls_to_psa_error(ret);
     }
 
@@ -330,7 +328,7 @@
                                                  key_buffer_size,
                                                  &rsa);
     if (status != PSA_SUCCESS) {
-        return status;
+        goto exit;
     }
 
     status = psa_rsa_decode_md_type(alg, hash_length, &md_alg);