commit 8b718b5a6663609b1ae29e2d2ec661cac38a8cad
author Janos Follath <janos.follath@arm.com> Mon Jul 25 11:31:02 2022 +0100
committer Janos Follath <janos.follath@arm.com> Fri Aug 05 17:08:52 2022 +0100
tree e0adeed5d2df824fa7a5cad9f3c93a3b2b01aadd
parent 23bdeca64d85ccb0c2d602643d814a291b262916

Add bounds check to residue input

Signed-off-by: Janos Follath <janos.follath@arm.com>

library/bignum_new.c

diff --git a/library/bignum_new.c b/library/bignum_new.c
index 04f6049..60f50ad 100644
--- a/library/bignum_new.c
+++ b/library/bignum_new.c
@@ -29,6 +29,7 @@
 #include "bignum_core.h"
 #include "bignum_mod.h"
 #include "bignum_mod_raw.h"
+#include "constant_time_internal.h"
 
 #if defined(MBEDTLS_PLATFORM_C)
 #include "mbedtls/platform.h"
@@ -92,13 +93,17 @@
 
 int mbedtls_mpi_mod_residue_setup( mbedtls_mpi_mod_residue *r,
                                    mbedtls_mpi_mod_modulus *m,
-                                   mbedtls_mpi_uint *X )
+                                   mbedtls_mpi_uint *p,
+                                   size_t pn )
 {
-    if( X == NULL || m == NULL || r == NULL || X >= m->p)
+    if( p == NULL || m == NULL || r == NULL )
+        return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
+
+    if( pn < m->n || !mbedtls_mpi_core_lt_ct( m->p, p, pn ) )
         return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
 
     r->n = m->n;
-    r->p = X;
+    r->p = p;
 
     return( 0 );
 }
@@ -447,16 +452,28 @@
                               unsigned char *buf,
                               size_t buflen )
 {
+    int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
+
     if( m->ext_rep & MBEDTLS_MPI_MOD_EXT_REP_LE )
-        return mbedtls_mpi_core_read_le( X, m->n, buf, buflen );
+        ret = mbedtls_mpi_core_read_le( X, m->n, buf, buflen );
 
     else if( m->ext_rep & MBEDTLS_MPI_MOD_EXT_REP_BE )
-        return mbedtls_mpi_core_read_be( X, m->n, buf, buflen );
-
+        ret = mbedtls_mpi_core_read_be( X, m->n, buf, buflen );
     else
         return( MBEDTLS_ERR_MPI_BAD_INPUT_DATA );
 
-    return( 0 );
+    if( ret != 0 )
+        goto cleanup;
+
+    if( !mbedtls_mpi_core_lt_ct( X, m->p, m->n ) )
+    {
+        ret = MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
+        goto cleanup;
+    }
+
+cleanup:
+
+    return( ret );
 }
 
 int mbedtls_mpi_mod_raw_write( mbedtls_mpi_uint *X,