commit 8ce1b1afc87c7551e3cb5efa99c1b2fce6ef953d
author Nick Child <nick.child@ibm.com> Wed Sep 14 14:51:23 2022 -0500
committer Nick Child <nick.child@ibm.com> Wed Sep 14 15:13:52 2022 -0500
tree cfa63fe1d6e83f48886ca39aaf9272207a7afa73
parent 34d5e931cf50a0647d13b05ac1577333b2c8a249

pkcs7: Correct various syntatical mistakes

Resond to feedback from the following comments:
 - use correct spacing [1-7]
 - remove unnecessary parenthesis [8]
 - fixup comments [9-11]
 - remove unnecessary init work [12]
 - use var instead of type for sizeof [13]
[1] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953655691
[2] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953661514
[3] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953689929
[4] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953696384
[5] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697558
[6] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697793
[7] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953697951
[8] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r953699102
[9] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r971223775
[10] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967133905
[11] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967135932
[12] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967151430
[13] https://github.com/Mbed-TLS/mbedtls/pull/3431#discussion_r967154159
Signed-off-by: Nick Child <nick.child@ibm.com>

tests/suites/test_suite_pkcs7.function

diff --git a/tests/suites/test_suite_pkcs7.function b/tests/suites/test_suite_pkcs7.function
index 8db3f3f..c5094bc 100644
--- a/tests/suites/test_suite_pkcs7.function
+++ b/tests/suites/test_suite_pkcs7.function
@@ -76,15 +76,15 @@
 
     datalen = st.st_size;
     data = mbedtls_calloc( datalen, 1 );
-    TEST_ASSERT( data != NULL);
+    TEST_ASSERT( data != NULL );
 
     buflen = fread( (void *)data , sizeof( unsigned char ), datalen, file );
-    TEST_ASSERT( buflen == datalen);
+    TEST_ASSERT( buflen == datalen );
     fclose( file );
 
     if( do_hash_alg )
     {
-        res = mbedtls_oid_get_md_alg( &(pkcs7.signed_data.digest_alg_identifiers), &md_alg );
+        res = mbedtls_oid_get_md_alg( &pkcs7.signed_data.digest_alg_identifiers, &md_alg );
         TEST_ASSERT( res == 0 );
         TEST_ASSERT( md_alg == (mbedtls_md_type_t) do_hash_alg );
         md_info = mbedtls_md_info_from_type( md_alg );
@@ -162,7 +162,7 @@
 
     if( do_hash_alg )
     {
-        res = mbedtls_oid_get_md_alg( &(pkcs7.signed_data.digest_alg_identifiers), &md_alg );
+        res = mbedtls_oid_get_md_alg( &pkcs7.signed_data.digest_alg_identifiers, &md_alg );
         TEST_ASSERT( res == 0 );
         TEST_ASSERT( md_alg == MBEDTLS_MD_SHA256 );
 
@@ -171,7 +171,7 @@
         res = mbedtls_md( md_info, data, datalen, hash );
         TEST_ASSERT( res == 0 );
 
-        res = mbedtls_pkcs7_signed_hash_verify( &pkcs7, &x509_1, hash, sizeof(hash));
+        res = mbedtls_pkcs7_signed_hash_verify( &pkcs7, &x509_1, hash, sizeof(hash) );
         TEST_ASSERT( res == res_expect );
     }
     else