commit 8e8898d40ff25042dbc5db8f8eb7874a381dce6a
author Ronald Cron <ronald.cron@arm.com> Thu Jul 30 14:18:02 2020 +0200
committer Ronald Cron <ronald.cron@arm.com> Thu Jul 30 16:08:50 2020 +0200
tree 3f96953d833b4cba5cec20e0cbd00cf9a710f779
parent 4bdc13ff09033459786df534679746e7ac6e8f3b

tests: Replace "TEST_ASSERT(!memcmp ...)" by ASSERT_COMPARE

The usage of "!memcmp()" is at least not recommended
and better to use the macro dedicated for buffer
comparisons.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

tests/suites/test_suite_aria.function

diff --git a/tests/suites/test_suite_aria.function b/tests/suites/test_suite_aria.function
index 3cc683b..6d6a203 100644
--- a/tests/suites/test_suite_aria.function
+++ b/tests/suites/test_suite_aria.function
@@ -226,8 +226,8 @@
                                                  output + i ) == 0 );
         }
 
-        TEST_ASSERT( !memcmp( output,
-                              expected_output->x, expected_output->len) );
+        ASSERT_COMPARE( output, expected_output->len,
+                        expected_output->x, expected_output->len );
     }
 
 exit:
@@ -256,8 +256,8 @@
                                                  output + i ) == 0 );
         }
 
-        TEST_ASSERT( !memcmp( output,
-                              expected_output->x, expected_output->len) );
+        ASSERT_COMPARE( output, expected_output->len,
+                        expected_output->x, expected_output->len );
     }
 
 exit:
@@ -282,8 +282,8 @@
                                          output ) == cbc_result );
     if( cbc_result == 0 )
     {
-        TEST_ASSERT( !memcmp( output,
-                              expected_output->x, expected_output->len) );
+        ASSERT_COMPARE( output, expected_output->len,
+                        expected_output->x, expected_output->len );
     }
 
 exit:
@@ -308,8 +308,8 @@
                                          output ) == cbc_result );
     if( cbc_result == 0 )
     {
-        TEST_ASSERT( !memcmp( output,
-                              expected_output->x, expected_output->len) );
+        ASSERT_COMPARE( output, expected_output->len,
+                        expected_output->x, expected_output->len );
     }
 
 exit:
@@ -335,7 +335,8 @@
                                             iv_str->x, src_str->x, output )
                  == result );
 
-    TEST_ASSERT( !memcmp( output, expected_output->x, expected_output->len) );
+    ASSERT_COMPARE( output, expected_output->len,
+                    expected_output->x, expected_output->len );
 
 exit:
     mbedtls_aria_free( &ctx );
@@ -360,7 +361,8 @@
                                             iv_str->x, src_str->x, output )
                  == result );
 
-    TEST_ASSERT( !memcmp( output, expected_output->x, expected_output->len) );
+    ASSERT_COMPARE( output, expected_output->len,
+                    expected_output->x, expected_output->len );
 
 exit:
     mbedtls_aria_free( &ctx );
@@ -385,7 +387,8 @@
                                          iv_str->x, blk, src_str->x, output )
                  == result );
 
-    TEST_ASSERT( !memcmp( output, expected_output->x, expected_output->len) );
+    ASSERT_COMPARE( output, expected_output->len,
+                    expected_output->x, expected_output->len );
 
 exit:
     mbedtls_aria_free( &ctx );
@@ -410,7 +413,8 @@
                                          iv_str->x, blk, src_str->x, output )
                  == result );
 
-    TEST_ASSERT( !memcmp( output, expected_output->x, expected_output->len) );
+    ASSERT_COMPARE( output, expected_output->len,
+                    expected_output->x, expected_output->len );
 
 exit:
     mbedtls_aria_free( &ctx );