commit 8e8898d40ff25042dbc5db8f8eb7874a381dce6a
author Ronald Cron <ronald.cron@arm.com> Thu Jul 30 14:18:02 2020 +0200
committer Ronald Cron <ronald.cron@arm.com> Thu Jul 30 16:08:50 2020 +0200
tree 3f96953d833b4cba5cec20e0cbd00cf9a710f779
parent 4bdc13ff09033459786df534679746e7ac6e8f3b

tests: Replace "TEST_ASSERT(!memcmp ...)" by ASSERT_COMPARE

The usage of "!memcmp()" is at least not recommended
and better to use the macro dedicated for buffer
comparisons.

Signed-off-by: Ronald Cron <ronald.cron@arm.com>

tests/suites/test_suite_poly1305.function

diff --git a/tests/suites/test_suite_poly1305.function b/tests/suites/test_suite_poly1305.function
index 0fc1f60..4b8995b 100644
--- a/tests/suites/test_suite_poly1305.function
+++ b/tests/suites/test_suite_poly1305.function
@@ -22,7 +22,8 @@
     TEST_ASSERT( mbedtls_poly1305_mac( key->x, src_str->x,
                                        src_str->len, mac ) == 0 );
 
-    TEST_ASSERT( !memcmp( mac, expected_mac->x, expected_mac->len ) );
+    ASSERT_COMPARE( mac, expected_mac->len,
+                    expected_mac->x, expected_mac->len );
 
     /*
      * Test the streaming API
@@ -35,7 +36,8 @@
 
     TEST_ASSERT( mbedtls_poly1305_finish( &ctx, mac ) == 0 );
 
-    TEST_ASSERT( !memcmp( mac, expected_mac->x, expected_mac->len ) );
+    ASSERT_COMPARE( mac, expected_mac->len,
+                    expected_mac->x, expected_mac->len );
 
     /*
      * Test the streaming API again, piecewise
@@ -52,7 +54,8 @@
 
         TEST_ASSERT( mbedtls_poly1305_finish( &ctx, mac ) == 0 );
 
-        TEST_ASSERT( !memcmp( mac, expected_mac->x, expected_mac->len ) );
+        ASSERT_COMPARE( mac, expected_mac->len,
+                        expected_mac->x, expected_mac->len );
     }
 
     /*
@@ -68,7 +71,8 @@
 
         TEST_ASSERT( mbedtls_poly1305_finish( &ctx, mac ) == 0 );
 
-        TEST_ASSERT( !memcmp( mac, expected_mac->x, expected_mac->len ) );
+        ASSERT_COMPARE( mac, expected_mac->len,
+                        expected_mac->x, expected_mac->len );
     }
 
     mbedtls_poly1305_free( &ctx );