commit 90117db5dc75508533ce1ed7bf08f5ea567145d6
author Andrzej Kurek <andrzej.kurek@arm.com> Tue Apr 18 07:32:47 2023 -0400
committer Andrzej Kurek <andrzej.kurek@arm.com> Tue Apr 18 10:43:35 2023 -0400
tree 74895afac109d6e8cd7fd88d2ec3b924a1a436f6
parent af04f6307f861416c544b8c6164cf48a9b5e3aaf

Split a complex condition into separate ones

Make it more readable
Signed-off-by: Andrzej Kurek <andrzej.kurek@arm.com>

library/x509_crt.c

diff --git a/library/x509_crt.c b/library/x509_crt.c
index fc62057..cddbcdb 100644
--- a/library/x509_crt.c
+++ b/library/x509_crt.c
@@ -2637,12 +2637,15 @@
         }
         ++p;
     } while (nonzero_groups < 8);
-    if ((zero_group_start != -1 ? nonzero_groups > 6 : nonzero_groups != 8) ||
-        *p != '\0') {
+
+    if (*p != '\0') {
         return -1;
     }
 
     if (zero_group_start != -1) {
+        if (nonzero_groups > 6) {
+            return -1;
+        }
         int zero_groups = 8 - nonzero_groups;
         int groups_after_zero = nonzero_groups - zero_group_start;
 
@@ -2653,6 +2656,10 @@
                     groups_after_zero * sizeof(*addr));
         }
         memset(addr + zero_group_start, 0, zero_groups * sizeof(*addr));
+    } else {
+        if (nonzero_groups != 8) {
+            return -1;
+        }
     }
     memcpy(dst, addr, sizeof(addr));
     return 0;