commit 9073f7dd3b71d7a27c9112de2871f3a98173fb5d
author Gabor Mezei <gabor.mezei@arm.com> Mon Jan 23 19:05:37 2023 +0100
committer Gabor Mezei <gabor.mezei@arm.com> Mon Jan 23 19:05:37 2023 +0100
tree 58d6b00fb8f59eb1a2484421436c15692950e928
parent e81a2b85c91a660ed7fc8322fdad8f57016a6e20

Remove unneeded check

The fix_quasi_reduction function changed to static so checking the
invalid arguments are not needed anymore.

Signed-off-by: Gabor Mezei <gabor.mezei@arm.com>

library/bignum_mod_raw.c

diff --git a/library/bignum_mod_raw.c b/library/bignum_mod_raw.c
index b232182..049cdb2 100644
--- a/library/bignum_mod_raw.c
+++ b/library/bignum_mod_raw.c
@@ -129,18 +129,12 @@
 }
 
 MBEDTLS_STATIC_TESTABLE
-int mbedtls_mpi_mod_raw_fix_quasi_reduction(mbedtls_mpi_uint *X,
-                                            const mbedtls_mpi_mod_modulus *N)
+void mbedtls_mpi_mod_raw_fix_quasi_reduction(mbedtls_mpi_uint *X,
+                                             const mbedtls_mpi_mod_modulus *N)
 {
-    if (N->limbs == 0) {
-        return MBEDTLS_ERR_MPI_BAD_INPUT_DATA;
-    }
-
     mbedtls_mpi_uint c = mbedtls_mpi_core_sub(X, X, N->p, N->limbs);
 
     (void) mbedtls_mpi_core_add_if(X, N->p, N->limbs, (unsigned) c);
-
-    return 0;
 }
 
 /* END MERGE SLOT 2 */

library/bignum_mod_raw_invasive.h

diff --git a/library/bignum_mod_raw_invasive.h b/library/bignum_mod_raw_invasive.h
index 7770c0a..3550eaf 100644
--- a/library/bignum_mod_raw_invasive.h
+++ b/library/bignum_mod_raw_invasive.h
@@ -43,8 +43,8 @@
  * \return      #MBEDTLS_ERR_MPI_BAD_INPUT_DATA if \p N is invalid.
  */
 MBEDTLS_STATIC_TESTABLE
-int mbedtls_mpi_mod_raw_fix_quasi_reduction(mbedtls_mpi_uint *X,
-                                            const mbedtls_mpi_mod_modulus *N);
+void mbedtls_mpi_mod_raw_fix_quasi_reduction(mbedtls_mpi_uint *X,
+                                             const mbedtls_mpi_mod_modulus *N);
 
 #endif /* MBEDTLS_TEST_HOOKS */