commit 90e13fc3c62132e4dd1bc3b36f6dcee4895c7ef6
author Raef Coles <raef.coles@arm.com> Tue Oct 11 12:48:18 2022 +0100
committer Raef Coles <raef.coles@arm.com> Thu Oct 13 14:29:49 2022 +0100
tree f6e6525ef41059117e0490d30164469efbeaf5d7
parent 0dc604ed2b3f207571dd68f0286e23f51793779e

Add repro instructions for LMS test data

Add more interop tests, and use real data for the negative tests

Signed-off-by: Raef Coles <raef.coles@arm.com>

tests/suites/test_suite_lms.function

diff --git a/tests/suites/test_suite_lms.function b/tests/suites/test_suite_lms.function
index 9c966cf..f69ca9e 100644
--- a/tests/suites/test_suite_lms.function
+++ b/tests/suites/test_suite_lms.function
@@ -97,35 +97,35 @@
     /* Test negative cases if the input data is valid */
     if( expected_rc == 0 )
     {
-        /* Altering first message byte must cause verification failure */
-        msg->x[0] ^= 1;
-        TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
-                   MBEDTLS_ERR_LMS_VERIFY_FAILED);
-        msg->x[0] ^= 1;
+        if( msg->len >= 1 )
+        {
+            /* Altering first message byte must cause verification failure */
+            msg->x[0] ^= 1;
+            TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
+                       MBEDTLS_ERR_LMS_VERIFY_FAILED);
+            msg->x[0] ^= 1;
 
-        /* Altering last message byte must cause verification failure */
-        msg->x[msg->len - 1] ^= 1;
-        TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
-                   MBEDTLS_ERR_LMS_VERIFY_FAILED);
-        msg->x[msg->len - 1] ^= 1;
+            /* Altering last message byte must cause verification failure */
+            msg->x[msg->len - 1] ^= 1;
+            TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
+                       MBEDTLS_ERR_LMS_VERIFY_FAILED);
+            msg->x[msg->len - 1] ^= 1;
+        }
 
-        /* Altering first signature byte must cause verification failure */
-        sig->x[0] ^= 1;
-        TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
-                   MBEDTLS_ERR_LMS_VERIFY_FAILED);
-        sig->x[0] ^= 1;
+        if( sig->len >= 1 )
+        {
+            /* Altering first signature byte must cause verification failure */
+            sig->x[0] ^= 1;
+            TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
+                       MBEDTLS_ERR_LMS_VERIFY_FAILED);
+            sig->x[0] ^= 1;
 
-        /* Altering first signature byte must cause verification failure */
-        sig->x[0] ^= 1;
-        TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
-                   MBEDTLS_ERR_LMS_VERIFY_FAILED);
-        sig->x[0] ^= 1;
-
-        /* Altering last signature byte must cause verification failure */
-        sig->x[sig->len - 1] ^= 1;
-        TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
-                   MBEDTLS_ERR_LMS_VERIFY_FAILED);
-        sig->x[sig->len - 1] ^= 1;
+            /* Altering last signature byte must cause verification failure */
+            sig->x[sig->len - 1] ^= 1;
+            TEST_EQUAL(mbedtls_lms_verify( &ctx, msg->x, msg->len, sig->x, sig->len ),
+                       MBEDTLS_ERR_LMS_VERIFY_FAILED);
+            sig->x[sig->len - 1] ^= 1;
+        }
 
         /* Signatures of all sizes must not verify, whether shorter or longer */
         for( size = 0; size < sig->len; size++ ) {