commit 90f31b71a866b7813e0798b5424ba372eac7d803
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Oct 16 10:45:24 2018 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Oct 16 10:45:24 2018 +0200
tree 4cc00a4a82c7b4c084f6174d8cc52ada9c2828a9
parent a58e011ac06b1bc05df613345fdebc47c993cd6b

Improve readability by moving counter decrement

Avoid the slightly awkward rs_ctx-> i = i + 1

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 55d7eb8..66ad12e 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1711,9 +1711,11 @@
             MBEDTLS_MPI_CHK( ecp_randomize_jac( grp, R, f_rng, p_rng ) );
     }
 
-    while( i-- != 0 )
+    while( i != 0 )
     {
         MBEDTLS_ECP_BUDGET( MBEDTLS_ECP_OPS_DBL + MBEDTLS_ECP_OPS_ADD );
+        --i;
+
         MBEDTLS_MPI_CHK( ecp_double_jac( grp, R, R ) );
         MBEDTLS_MPI_CHK( ecp_select_comb( grp, &Txi, T, T_size, x[i] ) );
         MBEDTLS_MPI_CHK( ecp_add_mixed( grp, R, R, &Txi ) );
@@ -1727,8 +1729,7 @@
     if( rs_ctx != NULL && rs_ctx->rsm != NULL &&
         ret == MBEDTLS_ERR_ECP_IN_PROGRESS )
     {
-        /* was decreased before actually doing it */
-        rs_ctx->rsm->i = i + 1;
+        rs_ctx->rsm->i = i;
         /* no need to save R, already pointing to rs_ctx->rsm->R */
     }
 #endif