commit 95648b0134d555e9c26c61eb7ace331f749a7ca7
author Jerry Yu <jerry.h.yu@arm.com> Wed Dec 06 15:03:34 2023 +0800
committer Jerry Yu <jerry.h.yu@arm.com> Wed Dec 06 18:21:16 2023 +0800
tree b152270b2ce13ea18ea9bc417802a726196eaadd
parent c59c586ac4c761230107f2c58b57df6228d955ad

Some minor improvement

- move early data check to `prepare`
- avoid `((void) output_len)
- replace check with `session_ticket_allow`  in 2nd place

Signed-off-by: Jerry Yu <jerry.h.yu@arm.com>

library/ssl_tls13_server.c

diff --git a/library/ssl_tls13_server.c b/library/ssl_tls13_server.c
index 39caa9b..fe7a674 100644
--- a/library/ssl_tls13_server.c
+++ b/library/ssl_tls13_server.c
@@ -3137,6 +3137,15 @@
     mbedtls_ssl_session_set_ticket_flags(
         session, ssl->handshake->tls13_kex_modes);
 #endif
+
+#if defined(MBEDTLS_SSL_EARLY_DATA)
+    if (ssl->conf->early_data_enabled == MBEDTLS_SSL_EARLY_DATA_ENABLED &&
+        ssl->conf->max_early_data_size > 0) {
+        mbedtls_ssl_session_set_ticket_flags(
+            session, MBEDTLS_SSL_TLS1_3_TICKET_ALLOW_EARLY_DATA);
+    }
+#endif /* MBEDTLS_SSL_EARLY_DATA */
+
     MBEDTLS_SSL_PRINT_TICKET_FLAGS(4, session->ticket_flags);
 
     /* Generate ticket_age_add */
@@ -3242,21 +3251,10 @@
     size_t ticket_len;
     uint32_t ticket_lifetime;
     unsigned char *p_extensions_len;
-    size_t output_len;
-
-    ((void) output_len);
 
     *out_len = 0;
     MBEDTLS_SSL_DEBUG_MSG(2, ("=> write NewSessionTicket msg"));
 
-#if defined(MBEDTLS_SSL_EARLY_DATA)
-    if (ssl->conf->early_data_enabled == MBEDTLS_SSL_EARLY_DATA_ENABLED &&
-        ssl->conf->max_early_data_size > 0) {
-        mbedtls_ssl_session_set_ticket_flags(
-            session, MBEDTLS_SSL_TLS1_3_TICKET_ALLOW_EARLY_DATA);
-    }
-#endif /* MBEDTLS_SSL_EARLY_DATA */
-
     /*
      *    ticket_lifetime   4 bytes
      *    ticket_age_add    4 bytes
@@ -3323,8 +3321,9 @@
     p += 2;
 
 #if defined(MBEDTLS_SSL_EARLY_DATA)
-    if (ssl->conf->early_data_enabled == MBEDTLS_SSL_EARLY_DATA_ENABLED &&
-        ssl->conf->max_early_data_size > 0) {
+    if (mbedtls_ssl_session_ticket_allow_early_data(session)) {
+        size_t output_len;
+
         if ((ret = mbedtls_ssl_tls13_write_early_data_ext(
                  ssl, 1, p, end, &output_len)) != 0) {
             MBEDTLS_SSL_DEBUG_RET(