commit 967f8cde843675d6ecf88f53440c55a7be49bf54
author Moritz Fischer <moritzf@google.com> Sat Mar 02 00:55:06 2024 +0000
committer Moritz Fischer <moritzf@google.com> Tue Mar 05 22:32:32 2024 +0000
tree 9019fa93049ad313c8607133e5964361ebf2f9a6
parent e33b349c90d9aebf7b15521272947a5d8b0d02d7

library: psa_crypto: Explicitly initialize shared_secret

When building with -Og (specifically Zephyr with
CONFIG_DEBUG_OPTIMIZATIONS=y) one observes the following warning:

'shared_secret' may be used uninitialized [-Werror=maybe-uninitialized]

Fix this by zero initializing 'shared_secret' similar to the issue
addressed in commit 2fab5c960 ("Work around for GCC bug").

Signed-off-by: Moritz Fischer <moritzf@google.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index ca01e76..96b8250 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -7046,7 +7046,7 @@
                                                size_t peer_key_length)
 {
     psa_status_t status;
-    uint8_t shared_secret[PSA_RAW_KEY_AGREEMENT_OUTPUT_MAX_SIZE];
+    uint8_t shared_secret[PSA_RAW_KEY_AGREEMENT_OUTPUT_MAX_SIZE] = { 0 };
     size_t shared_secret_length = 0;
     psa_algorithm_t ka_alg = PSA_ALG_KEY_AGREEMENT_GET_BASE(operation->alg);