commit 994193326be25c29be2b525552db401d3e432067
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Oct 03 10:40:57 2019 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Oct 22 10:03:07 2019 +0200
tree 004e4ea1c7c18dbd6f65660d7c65342577bbeda0
parent 14f33e74c0452afec9740ab49e501027fedb80eb

Use plain memset() in context init functions

We call xxx_init() on a structure when it has been freshly allocated (on the
stack or heap).

At this point it contains random-looking data none of which should be
sensitive, as all sensitive data is wiped using mbedtls_platform_zeroize()
when we're done using it and the memory area is going to be reclaimed (by
exiting the function or free()ing the buffer).

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 64d3335..ddc58a4 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -7955,7 +7955,7 @@
 
 static void ssl_handshake_params_init( mbedtls_ssl_handshake_params *handshake )
 {
-    mbedtls_platform_memset( handshake, 0, sizeof( mbedtls_ssl_handshake_params ) );
+    memset( handshake, 0, sizeof( mbedtls_ssl_handshake_params ) );
 
 #if defined(MBEDTLS_SSL_PROTO_SSL3) || defined(MBEDTLS_SSL_PROTO_TLS1) || \
     defined(MBEDTLS_SSL_PROTO_TLS1_1)
@@ -8010,7 +8010,7 @@
 
 void mbedtls_ssl_transform_init( mbedtls_ssl_transform *transform )
 {
-    mbedtls_platform_memset( transform, 0, sizeof(mbedtls_ssl_transform) );
+    memset( transform, 0, sizeof(mbedtls_ssl_transform) );
 
     mbedtls_cipher_init( &transform->cipher_ctx_enc );
     mbedtls_cipher_init( &transform->cipher_ctx_dec );
@@ -8023,7 +8023,7 @@
 
 void mbedtls_ssl_session_init( mbedtls_ssl_session *session )
 {
-    mbedtls_platform_memset( session, 0, sizeof(mbedtls_ssl_session) );
+    memset( session, 0, sizeof(mbedtls_ssl_session) );
 }
 
 static int ssl_handshake_init( mbedtls_ssl_context *ssl )
@@ -8226,7 +8226,7 @@
  */
 void mbedtls_ssl_init( mbedtls_ssl_context *ssl )
 {
-    mbedtls_platform_memset( ssl, 0, sizeof( mbedtls_ssl_context ) );
+    memset( ssl, 0, sizeof( mbedtls_ssl_context ) );
 }
 
 /*
@@ -11773,7 +11773,7 @@
  */
 void mbedtls_ssl_config_init( mbedtls_ssl_config *conf )
 {
-    mbedtls_platform_memset( conf, 0, sizeof( mbedtls_ssl_config ) );
+    memset( conf, 0, sizeof( mbedtls_ssl_config ) );
 
 #if !defined(MBEDTLS_SSL_PROTO_TLS)
     conf->transport = MBEDTLS_SSL_TRANSPORT_DATAGRAM;