commit 998fbfbe6872e4d163d02d81f4c3966e86eb5262
author Gilles Peskine <Gilles.Peskine@arm.com> Wed Dec 19 17:08:51 2018 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Wed Dec 19 17:08:51 2018 +0100
tree 9b3791b58f09a801e334d0590a57ab8de3cc578d
parent cc274c2ebf784290533b04be16a72045a28ecdfe

Properly test pk_write with an empty output buffer

This needs a real key to test properly.

tests/suites/test_suite_pk.function

diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function
index b8069b5..20b5457 100644
--- a/tests/suites/test_suite_pk.function
+++ b/tests/suites/test_suite_pk.function
@@ -2,6 +2,8 @@
 #include "mbedtls/pk.h"
 
 /* For error codes */
+#include "mbedtls/asn1.h"
+#include "mbedtls/base64.h"
 #include "mbedtls/ecp.h"
 #include "mbedtls/rsa.h"
 
@@ -111,14 +113,36 @@
     TEST_ASSERT( mbedtls_pk_parse_public_key( &pk, NULL, 0 ) ==
                  MBEDTLS_ERR_PK_KEY_INVALID_FORMAT );
 #endif /* MBEDTLS_PK_PARSE_C */
+}
+/* END_CASE */
 
-#if defined(MBEDTLS_PK_WRITE_C)
+/* BEGIN_CASE depends_on:MBEDTLS_PK_WRITE_C */
+void valid_parameters_pkwrite( data_t *key_data )
+{
+    mbedtls_pk_context pk;
+
+    /* For the write tests to be effective, we need a valid key pair. */
+    mbedtls_pk_init( &pk );
+    TEST_ASSERT( mbedtls_pk_parse_key( &pk,
+                                       key_data->x, key_data->len,
+                                       NULL, 0 ) == 0 );
+
     TEST_ASSERT( mbedtls_pk_write_key_der( &pk, NULL, 0 ) ==
-                 MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE );
+                 MBEDTLS_ERR_ASN1_BUF_TOO_SMALL );
 
     TEST_ASSERT( mbedtls_pk_write_pubkey_der( &pk, NULL, 0 ) ==
-                 MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE );
-#endif /* MBEDTLS_PK_WRITE_C */
+                 MBEDTLS_ERR_ASN1_BUF_TOO_SMALL );
+
+#if defined(MBEDTLS_PEM_WRITE_C)
+    TEST_ASSERT( mbedtls_pk_write_key_pem( &pk, NULL, 0 ) ==
+                 MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL );
+
+    TEST_ASSERT( mbedtls_pk_write_pubkey_pem( &pk, NULL, 0 ) ==
+                 MBEDTLS_ERR_BASE64_BUFFER_TOO_SMALL );
+#endif /* MBEDTLS_PEM_WRITE_C */
+
+exit:
+    mbedtls_pk_free( &pk );
 }
 /* END_CASE */