commit 9a5b812aa812032a266b111a0667b33dff0ee10b
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Thu Dec 22 13:34:47 2022 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Wed Feb 22 11:30:31 2023 +0100
tree cd6df3a524e2ea9cbd891363ac983b68f37429e1
parent fcd70e250f5aaad993c29ec279a2b2bc2f95d764

Cleanup the code

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 0bb751b..f7b0270 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -898,7 +898,7 @@
     psa_algorithm_t alg)
 {
     psa_status_t status = PSA_ERROR_CORRUPTION_DETECTED;
-    psa_key_slot_t *slot;
+    psa_key_slot_t *slot = NULL;
 
     status = psa_get_and_lock_key_slot(key, p_slot);
     if (status != PSA_SUCCESS) {
@@ -7180,9 +7180,6 @@
     psa_pake_operation_t *operation,
     const psa_pake_cipher_suite_t *cipher_suite)
 {
-    psa_jpake_computation_stage_t *computation_stage =
-        &operation->computation_stage.data.jpake_computation_stage;
-
     if (operation->stage != PSA_PAKE_OPERATION_STAGE_COLLECT_INPUTS) {
         return PSA_ERROR_BAD_STATE;
     }
@@ -7205,6 +7202,9 @@
     operation->data.inputs.cipher_suite = *cipher_suite;
 
     if (operation->alg == PSA_ALG_JPAKE) {
+        psa_jpake_computation_stage_t *computation_stage =
+            &operation->computation_stage.data.jpake_computation_stage;
+
         computation_stage->state = PSA_PAKE_STATE_SETUP;
         computation_stage->sequence = PSA_PAKE_SEQ_INVALID;
         computation_stage->input_step = PSA_PAKE_STEP_X1_X2;
@@ -7260,7 +7260,6 @@
     operation->data.inputs.key_lifetime = attributes.core.lifetime;
 error:
     unlock_status = psa_unlock_key_slot(slot);
-
     return (status == PSA_SUCCESS) ? unlock_status : status;
 }
 
@@ -7603,7 +7602,6 @@
     return PSA_SUCCESS;
 }
 
-
 static psa_status_t psa_jpake_input_epilogue(
     psa_pake_operation_t *operation)
 {
@@ -7624,7 +7622,6 @@
     return PSA_SUCCESS;
 }
 
-
 psa_status_t psa_pake_input(
     psa_pake_operation_t *operation,
     psa_pake_step_t step,
@@ -7733,27 +7730,38 @@
 psa_status_t psa_pake_abort(
     psa_pake_operation_t *operation)
 {
-    psa_jpake_computation_stage_t *computation_stage =
-        &operation->computation_stage.data.jpake_computation_stage;
+    psa_status_t status = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
 
-    /* If we are in collecting inputs stage clear inputs. */
-    if (operation->stage == PSA_PAKE_OPERATION_STAGE_COLLECT_INPUTS) {
-        if (operation->data.inputs.password_len > 0) {
-            mbedtls_platform_zeroize(operation->data.inputs.password,
-                                     operation->data.inputs.password_len);
-            mbedtls_free(operation->data.inputs.password);
+    if (operation->id != 0) {
+        status = psa_driver_wrapper_pake_abort(operation);
+        if (status != PSA_SUCCESS) {
+            return status;
         }
-        memset(&operation->data.inputs, 0, sizeof(psa_crypto_driver_pake_inputs_t));
-        return PSA_SUCCESS;
     }
+
+    if (operation->data.inputs.password_len > 0) {
+        mbedtls_platform_zeroize(operation->data.inputs.password,
+                                 operation->data.inputs.password_len);
+        mbedtls_free(operation->data.inputs.password);
+    }
+
+    memset(&operation->data, 0, sizeof(operation->data));
+
     if (operation->alg == PSA_ALG_JPAKE) {
+        psa_jpake_computation_stage_t *computation_stage =
+            &operation->computation_stage.data.jpake_computation_stage;
+
         computation_stage->input_step = PSA_PAKE_STEP_INVALID;
         computation_stage->output_step = PSA_PAKE_STEP_INVALID;
         computation_stage->state = PSA_PAKE_STATE_INVALID;
         computation_stage->sequence = PSA_PAKE_SEQ_INVALID;
     }
 
-    return psa_driver_wrapper_pake_abort(operation);
+    operation->alg = PSA_ALG_NONE;
+    operation->stage = PSA_PAKE_OPERATION_STAGE_COLLECT_INPUTS;
+    operation->id = 0;
+
+    return PSA_SUCCESS;
 }
 
 #endif /* MBEDTLS_PSA_CRYPTO_C */