commit 9dfcae8b94a42a1d4eda735a3de92f92c401aca9
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Jun 16 10:00:18 2020 +0200
committer GitHub <noreply@github.com> Tue Jun 16 10:00:18 2020 +0200
tree bef2e600ebc5556f3f06900775446fbf241027fc
parent b21b1f5e7c04ff135197e91aac15915a25bb02aa
parent 6f1eda710ccc8e1e954dd072d4cd074ee804163b

Merge pull request #3426 from paul-elliott-arm/resource_leak

Fix for resource leak in test_suite_ssl

tests/suites/test_suite_ssl.function

diff --git a/tests/suites/test_suite_ssl.function b/tests/suites/test_suite_ssl.function
index 833efd4..5cf6e8b 100644
--- a/tests/suites/test_suite_ssl.function
+++ b/tests/suites/test_suite_ssl.function
@@ -1179,6 +1179,7 @@
 
     size_t keylen, maclen, ivlen;
     unsigned char *key0 = NULL, *key1 = NULL;
+    unsigned char *md0 = NULL, *md1 = NULL;
     unsigned char iv_enc[16], iv_dec[16];
 
 #if defined(MBEDTLS_SSL_DTLS_CONNECTION_ID)
@@ -1245,7 +1246,6 @@
         cipher_info->mode == MBEDTLS_MODE_STREAM )
     {
         mbedtls_md_info_t const *md_info;
-        unsigned char *md0, *md1;
 
         /* Pick hash */
         md_info = mbedtls_md_info_from_type( hash_id );
@@ -1283,9 +1283,6 @@
             memcpy( &t_out->mac_dec, md0, maclen );
         }
 #endif
-
-        mbedtls_free( md0 );
-        mbedtls_free( md1 );
     }
 #else
     ((void) hash_id);
@@ -1417,6 +1414,9 @@
     mbedtls_free( key0 );
     mbedtls_free( key1 );
 
+    mbedtls_free( md0 );
+    mbedtls_free( md1 );
+
     return( ret );
 }