commit a9ca13136c6591d492ecc5f015478275d817e3b7
author Przemek Stekiel <przemyslaw.stekiel@mobica.com> Mon Dec 05 15:02:32 2022 +0100
committer Przemek Stekiel <przemyslaw.stekiel@mobica.com> Wed Apr 26 09:07:20 2023 +0200
tree 012a7b25142db68746f8cbdccaef3ed5208ed056
parent 0dd746d998e2a071ff750815029e41837f190284

Move check of the key type to mbedtls_psa_key_agreement_ffdh

Signed-off-by: Przemek Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index 5d8540c..98dad9d 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -6594,10 +6594,6 @@
 
 #if defined(MBEDTLS_PSA_BUILTIN_ALG_FFDH)
         case PSA_ALG_FFDH:
-            if (!PSA_KEY_TYPE_IS_DH_KEY_PAIR(psa_get_key_type(attributes))) {
-                return PSA_ERROR_INVALID_ARGUMENT;
-            }
-
             return mbedtls_psa_key_agreement_ffdh(attributes,
                                                   peer_key,
                                                   peer_key_length,

library/psa_crypto_ffdh.c

diff --git a/library/psa_crypto_ffdh.c b/library/psa_crypto_ffdh.c
index d8c153a..6b07a7d 100644
--- a/library/psa_crypto_ffdh.c
+++ b/library/psa_crypto_ffdh.c
@@ -131,6 +131,10 @@
         return PSA_ERROR_INVALID_ARGUMENT;
     }
 
+    if (!PSA_KEY_TYPE_IS_DH_KEY_PAIR(psa_get_key_type(attributes))) {
+        return PSA_ERROR_INVALID_ARGUMENT;
+    }
+
     mbedtls_mpi_init(&P); mbedtls_mpi_init(&G);
     mbedtls_mpi_init(&X); mbedtls_mpi_init(&GY);
     mbedtls_mpi_init(&K);