commit acfdc623d2d47457a1f4c98bc4db373b5d143e36
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Dec 11 10:36:21 2018 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Tue Dec 11 12:28:56 2018 +0100
tree f4a733c051a0f98b9ae9b48e813a650779c6eaf7
parent 840af0a9ae6b8d7797786c5a6e3d83cec3417a7b

Fix test macro that was too lenient

Previously, one could change the definition of AES_VALIDATE_RET() to return
some other code than MBEDTLS_ERR_AES_BAD_INPUT_DATA, and the test suite
wouldn't notice. Now this modification would make the suite fail as expected.

tests/suites/helpers.function

diff --git a/tests/suites/helpers.function b/tests/suites/helpers.function
index 57bc259..b5bd31e 100644
--- a/tests/suites/helpers.function
+++ b/tests/suites/helpers.function
@@ -133,7 +133,7 @@
 #define TEST_INVALID_PARAM_RET( PARAM_ERR_VALUE, TEST )                     \
     do {                                                                    \
         test_info.paramfail_test_state = PARAMFAIL_TESTSTATE_PENDING;       \
-        if( (TEST) != (PARAM_ERR_VALUE) &&                                  \
+        if( (TEST) != (PARAM_ERR_VALUE) ||                                  \
             test_info.paramfail_test_state != PARAMFAIL_TESTSTATE_CALLED )  \
         {                                                                   \
             test_fail( #TEST, __LINE__, __FILE__ );                         \