commit ae449bfca5e9a9a7b1cf1ec777755e33c79488e4
author Minos Galanakis <minos.galanakis@arm.com> Mon Jun 02 14:33:47 2025 +0100
committer Minos Galanakis <minos.galanakis@arm.com> Wed Jun 04 15:54:49 2025 +0100
tree 32cf6af8c96679f29d36f3e033534f6ed2cf6bdf
parent caaffc1e7ec1a120821dea1f00a441e7b271c63d

Built-in lms driver:Check return values of Merkle node creation

Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>

library/lms.c

diff --git a/library/lms.c b/library/lms.c
index 8d1840c..78886ab 100644
--- a/library/lms.c
+++ b/library/lms.c
@@ -374,12 +374,16 @@
         return MBEDTLS_ERR_LMS_VERIFY_FAILED;
     }
 
-    create_merkle_leaf_value(
+    ret = create_merkle_leaf_value(
         &ctx->params,
         Kc_candidate_ots_pub_key,
         MERKLE_TREE_INTERNAL_NODE_AM(ctx->params.type) + q_leaf_identifier,
         Tc_candidate_root_node);
 
+    if (ret != 0) {
+        return MBEDTLS_ERR_LMS_VERIFY_FAILED;
+    }
+
     curr_node_id = MERKLE_TREE_INTERNAL_NODE_AM(ctx->params.type) +
                    q_leaf_identifier;
 
@@ -398,9 +402,11 @@
                          height * MBEDTLS_LMS_M_NODE_BYTES(ctx->params.type);
         }
 
-        create_merkle_internal_value(&ctx->params, left_node, right_node,
-                                     parent_node_id, Tc_candidate_root_node);
-
+        ret = create_merkle_internal_value(&ctx->params, left_node, right_node,
+                                           parent_node_id, Tc_candidate_root_node);
+        if (ret != 0) {
+            return MBEDTLS_ERR_LMS_VERIFY_FAILED;
+        }
         curr_node_id /= 2;
     }