commit af70c7dce772076cfa17c0d07c266fae8919a913
author Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com> Thu Aug 10 16:39:23 2023 +0100
committer Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com> Tue Aug 22 10:39:56 2023 +0100
tree 1feca89736462e2a543cb9db7150339859ef5c0c
parent a7f96309255ebf97d0ff3263eec7537a92c04cc1

Write numeric oid directly to buffer

mbedtls_oid_get_numeric_string now points to output buffer in dn_gets

Signed-off-by: Agathiyan Bragadeesh <agathiyan.bragadeesh2@arm.com>

library/x509.c

diff --git a/library/x509.c b/library/x509.c
index b487b43..74b2fd6 100644
--- a/library/x509.c
+++ b/library/x509.c
@@ -833,7 +833,6 @@
     const mbedtls_x509_name *name;
     const char *short_name = NULL;
     char lowbits, highbits;
-    char numericoid[256];
     char s[MBEDTLS_X509_MAX_DN_NAME_SIZE], *p;
     int print_hexstring;
 
@@ -861,8 +860,9 @@
         if ((ret = mbedtls_oid_get_attr_short_name(&name->oid, &short_name)) == 0) {
             ret = mbedtls_snprintf(p, n, "%s=", short_name);
         } else {
-            if ((ret = mbedtls_oid_get_numeric_string(numericoid, 256, &name->oid)) > 0) {
-                ret = mbedtls_snprintf(p, n, "%s=", numericoid);
+            if ((ret = mbedtls_oid_get_numeric_string(p, n, &name->oid)) > 0) {
+                MBEDTLS_X509_SAFE_SNPRINTF;
+                ret = mbedtls_snprintf(p, n, "=");
                 print_hexstring = 1;
             } else {
                 ret = mbedtls_snprintf(p, n, "\?\?=");