commit b3c2eaf00fde007eb402dc714bf7ddda37218316
author Gilles Peskine <Gilles.Peskine@arm.com> Sun Dec 04 13:10:55 2022 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Wed Apr 26 19:40:02 2023 +0200
tree b29e2e991eeade7dc9af2e0cbe5a672f430c4065
parent 5226eb5cd39180aac91563c7b5b75dc321bae02b

Support different types in the parameter store

The test framework stores size_t and int32_t values in the parameter store
by converting them all to int. This is ok in practice, since we assume int
covers int32_t and we don't have test data larger than 2GB. But it's
confusing and error-prone. So make the parameter store a union, which allows
size_t values not to be potentially truncated and makes the code a little
clearer.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

tests/scripts/generate_test_code.py

diff --git a/tests/scripts/generate_test_code.py b/tests/scripts/generate_test_code.py
index 6b5f11b..54c7e3a 100755
--- a/tests/scripts/generate_test_code.py
+++ b/tests/scripts/generate_test_code.py
@@ -471,7 +471,7 @@
             continue
         if re.search(INT_CHECK_REGEX, arg.strip()):
             args.append('int')
-            args_dispatch.append('*( (int *) params[%d] )' % arg_idx)
+            args_dispatch.append('((mbedtls_test_argument_t*)params[%d])->s32' % arg_idx)
         elif re.search(CHAR_CHECK_REGEX, arg.strip()):
             args.append('char*')
             args_dispatch.append('(char *) params[%d]' % arg_idx)
@@ -479,7 +479,7 @@
             args.append('hex')
             # create a structure
             pointer_initializer = '(uint8_t *) params[%d]' % arg_idx
-            len_initializer = '*( (uint32_t *) params[%d] )' % (arg_idx+1)
+            len_initializer = '((mbedtls_test_argument_t*)params[%d])->len' % (arg_idx+1)
             local_vars += """    data_t data%d = {%s, %s};
 """ % (arg_idx, pointer_initializer, len_initializer)
 

tests/scripts/test_generate_test_code.py

diff --git a/tests/scripts/test_generate_test_code.py b/tests/scripts/test_generate_test_code.py
index 9a78ca1..c198ad0 100755
--- a/tests/scripts/test_generate_test_code.py
+++ b/tests/scripts/test_generate_test_code.py
@@ -485,9 +485,10 @@
         args, local, arg_dispatch = parse_function_arguments(line)
         self.assertEqual(args, ['char*', 'int', 'int'])
         self.assertEqual(local, '')
-        self.assertEqual(arg_dispatch, ['(char *) params[0]',
-                                        '*( (int *) params[1] )',
-                                        '*( (int *) params[2] )'])
+        self.assertEqual(arg_dispatch,
+                         ['(char *) params[0]',
+                          '((mbedtls_test_argument_t*)params[1])->s32',
+                          '((mbedtls_test_argument_t*)params[2])->s32'])
 
     def test_hex_params(self):
         """
@@ -499,10 +500,10 @@
         self.assertEqual(args, ['char*', 'hex', 'int'])
         self.assertEqual(local,
                          '    data_t data1 = {(uint8_t *) params[1], '
-                         '*( (uint32_t *) params[2] )};\n')
+                         '((mbedtls_test_argument_t*)params[2])->len};\n')
         self.assertEqual(arg_dispatch, ['(char *) params[0]',
                                         '&data1',
-                                        '*( (int *) params[3] )'])
+                                        '((mbedtls_test_argument_t*)params[3])->s32'])
 
     def test_unsupported_arg(self):
         """