commit b3f20da31382568f99a4f5c08239bf00b985c617
author Valerio Setti <valerio.setti@nordicsemi.no> Tue Apr 04 11:19:33 2023 +0200
committer Valerio Setti <valerio.setti@nordicsemi.no> Tue Apr 11 09:16:24 2023 +0200
tree 390097d7e575baa4a95ef69e4160a6d277239a91
parent 12a063abb75999605a1f2b3c2aba3eee8cd10559

test: fix error handling in the new pk_genkey_ec() function

Signed-off-by: Valerio Setti <valerio.setti@nordicsemi.no>

tests/suites/test_suite_pk.function

diff --git a/tests/suites/test_suite_pk.function b/tests/suites/test_suite_pk.function
index f09cc94..2e374fe 100644
--- a/tests/suites/test_suite_pk.function
+++ b/tests/suites/test_suite_pk.function
@@ -48,30 +48,28 @@
 
     status = psa_export_key(key_id, key_buf, sizeof(key_buf), &key_len);
     if (status != PSA_SUCCESS) {
-        psa_destroy_key(key_id);
-        return MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE;
+        ret = MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE;
+        goto exit;
     }
 
     ret = mbedtls_mpi_read_binary(d, key_buf, key_len);
     if (ret != 0) {
-        return ret;
+        goto exit;
     }
 
     status = psa_export_public_key(key_id, key_buf, sizeof(key_buf),
                                    &key_len);
     if (status != PSA_SUCCESS) {
-        psa_destroy_key(key_id);
-        return MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE;
+        ret = MBEDTLS_ERR_PK_FEATURE_UNAVAILABLE;
+        goto exit;
     }
 
     ret = mbedtls_ecp_point_read_binary(grp, Q, key_buf, key_len);
-    if (ret != 0) {
-        return ret;
-    }
 
+exit:
     psa_destroy_key(key_id);
 
-    return 0;
+    return ret;
 }
 
 /** Generate a key of the desired type.