commit b603bd34bc370d9a32c6762cfb067e7918bd0146
author Hanno Becker <hanno.becker@arm.com> Wed Jul 10 09:45:44 2019 +0100
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Aug 01 09:50:26 2019 +0200
tree e7c42757a0446840b0d4aafa00738590d3f8b8b7
parent f024285034abe8e079eb38b5a7c67903912d5e10

Remove assertion in mbedtls_ssl_decrypt_buf()

mbedtls_ssl_decrypt_buf() asserts that the passed transform is not NULL,
but the function is only invoked in a single place, and this invocation
is clearly visible to be within a branch ensuring that the incoming
transform isn't NULL. Remove the assertion for the benefit of code-size.

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index ab33d8b..5f27e2d 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -2368,11 +2368,6 @@
 #endif
 
     MBEDTLS_SSL_DEBUG_MSG( 2, ( "=> decrypt buf" ) );
-    if( transform == NULL )
-    {
-        MBEDTLS_SSL_DEBUG_MSG( 1, ( "no transform provided to decrypt_buf" ) );
-        return( MBEDTLS_ERR_SSL_INTERNAL_ERROR );
-    }
     if( rec == NULL                     ||
         rec->buf == NULL                ||
         rec->buf_len < rec->data_offset ||