commit b81fcd00e64b7c6e534fe56eb23a1c58a1cbd408
author Hanno Becker <hanno.becker@arm.com> Wed May 03 15:09:31 2017 +0100
committer Hanno Becker <hanno.becker@arm.com> Tue Mar 13 10:31:02 2018 +0000
tree 17cb6a744bc82bd23ab98493f78e157040ebc43f
parent d43764f9d3620b44b5d977ec9c229e0bf41051c5

Correct memory leak in RSA self test

The RSA self test didn't free the RSA context on failure.

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index 0d698f7..9324f45 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -1790,7 +1790,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( verbose != 0 )
@@ -1804,7 +1805,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( verbose != 0 )
@@ -1817,7 +1819,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( memcmp( rsa_decrypted, rsa_plaintext, len ) != 0 )
@@ -1825,7 +1828,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( verbose != 0 )
@@ -1843,7 +1847,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( verbose != 0 )
@@ -1855,7 +1860,8 @@
         if( verbose != 0 )
             mbedtls_printf( "failed\n" );
 
-        return( 1 );
+        ret = 1;
+        goto cleanup;
     }
 
     if( verbose != 0 )