commit b9cd19bc8c6196511eb1d10094c62e58e5da6eed
author Dave Rodgman <dave.rodgman@arm.com> Fri Dec 30 21:32:03 2022 +0000
committer Dave Rodgman <dave.rodgman@arm.com> Fri Jan 20 14:04:48 2023 +0000
tree 92a3afe00130bc623c84eca65ea99ba4898b3fc3
parent 051225d07abf20df3cb2d03ab4b1ee8c7024089f

Prevent perf regressions in mbedtls_xor

Signed-off-by: Dave Rodgman <dave.rodgman@arm.com>

library/alignment.h

diff --git a/library/alignment.h b/library/alignment.h
index bfc965e..aa4c430 100644
--- a/library/alignment.h
+++ b/library/alignment.h
@@ -29,6 +29,19 @@
 
 #include "mbedtls/build_info.h"
 
+/*
+ * Define MBEDTLS_EFFICIENT_UNALIGNED_ACCESS for architectures where unaligned memory
+ * accesses are known to be safe and efficient.
+ */
+#if defined(__ARM_FEATURE_UNALIGNED) \
+    || defined(__i386__) || defined(__amd64__) || defined(__x86_64__)
+/*
+ * __ARM_FEATURE_UNALIGNED is defined where appropriate by armcc, gcc 7, clang 9
+ * (and later versions); all x86 platforms should have efficient unaligned access.
+ */
+#define MBEDTLS_EFFICIENT_UNALIGNED_ACCESS
+#endif
+
 /**
  * Read the unsigned 16 bits integer from the given address, which need not
  * be aligned.

library/common.h

diff --git a/library/common.h b/library/common.h
index fd3ddba..ae6625b 100644
--- a/library/common.h
+++ b/library/common.h
@@ -122,11 +122,13 @@
  */
 inline void mbedtls_xor(unsigned char *r, const unsigned char *a, const unsigned char *b, size_t n)
 {
-    size_t i;
-    for (i = 0; (i + 4) <= n; i += 4) {
+    size_t i = 0;
+#if defined(MBEDTLS_EFFICIENT_UNALIGNED_ACCESS)
+    for (; (i + 4) <= n; i += 4) {
         uint32_t x = mbedtls_get_unaligned_uint32(a + i) ^ mbedtls_get_unaligned_uint32(b + i);
         mbedtls_put_unaligned_uint32(r + i, x);
     }
+#endif
     for (; i < n; i++) {
         r[i] = a[i] ^ b[i];
     }

library/constant_time.c

diff --git a/library/constant_time.c b/library/constant_time.c
index 309e11c..89778d5 100644
--- a/library/constant_time.c
+++ b/library/constant_time.c
@@ -48,15 +48,6 @@
 #include <string.h>
 
 /*
- * Define MBEDTLS_EFFICIENT_UNALIGNED_ACCESS for architectures where unaligned memory
- * accesses are known to be safe and efficient.
- */
-#if defined(__ARM_FEATURE_UNALIGNED)
-/* __ARM_FEATURE_UNALIGNED is defined by armcc, gcc 7, clang 9 and later versions */
-#define MBEDTLS_EFFICIENT_UNALIGNED_ACCESS
-#endif
-
-/*
  * Define MBEDTLS_EFFICIENT_UNALIGNED_VOLATILE_ACCESS where assembly is present to
  * perform fast unaligned access to volatile data.
  *