commit bcc030849a1615528287fa5a7276cf3335be51d2
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Wed Jun 24 00:09:29 2015 +0200
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Wed Jun 24 00:09:29 2015 +0200
tree 30208338b206ae98aa57806b839dac230fbd111e
parent 7f9049baf4caed031e2ccdcf41db9f687f568d2e

Avoid fclose( NULL )

Found by Coverity Scan.

library/md.c

diff --git a/library/md.c b/library/md.c
index 1d6191f..1220a87 100644
--- a/library/md.c
+++ b/library/md.c
@@ -284,13 +284,10 @@
     if( md_info == NULL )
         return( MBEDTLS_ERR_MD_BAD_INPUT_DATA );
 
-    mbedtls_md_init( &ctx );
-
     if( ( f = fopen( path, "rb" ) ) == NULL )
-    {
-        ret = MBEDTLS_ERR_MD_FILE_IO_ERROR;
-        goto cleanup;
-    }
+        return( MBEDTLS_ERR_MD_FILE_IO_ERROR );
+
+    mbedtls_md_init( &ctx );
 
     if( ( ret = mbedtls_md_setup( &ctx, md_info, 0 ) ) != 0 )
         goto cleanup;