commit be04673c49945d0607bb224db5cb2264fb645c7a
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Mon Mar 10 21:20:29 2014 +0100
committer Paul Bakker <p.j.bakker@polarssl.org> Tue Jul 08 11:04:19 2014 +0200
tree 0096a3489bbece42c0fa2edfcad0d603f35a7137
parent 50a5c53398b5ffc3cc997a8c7d432a025c8de2f3

Forbid sequence number wrapping

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index d6e9dd3..c42eccc 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -1191,6 +1191,13 @@
         if( ++ssl->out_ctr[i - 1] != 0 )
             break;
 
+    /* The loops goes to its end iff the counter is wrapping */
+    if( i == 0 )
+    {
+        SSL_DEBUG_MSG( 1, ( "outgoing message counter would wrap" ) );
+        return( POLARSSL_ERR_SSL_COUNTER_WRAPPING );
+    }
+
     SSL_DEBUG_MSG( 2, ( "<= encrypt buf" ) );
 
     return( 0 );
@@ -1589,6 +1596,13 @@
         if( ++ssl->in_ctr[i - 1] != 0 )
             break;
 
+    /* The loops goes to its end iff the counter is wrapping */
+    if( i == 0 )
+    {
+        SSL_DEBUG_MSG( 1, ( "incoming message counter would wrap" ) );
+        return( POLARSSL_ERR_SSL_COUNTER_WRAPPING );
+    }
+
     SSL_DEBUG_MSG( 2, ( "<= decrypt buf" ) );
 
     return( 0 );