commit bee71453b2643445427c6ff49e2d12fd2491f3ca
author XiaokangQian <xiaokang.qian@arm.com> Thu Jul 21 08:19:06 2022 +0000
committer Ronald Cron <ronald.cron@arm.com> Thu Jul 21 15:30:04 2022 +0200
tree 6863b0b6c23b25de73a8fca5e0b470b676185094
parent 3ad67bf4e384d71f5f85309c6a397e822c8b29f1

Improve the buffer pointer check in write pre_shared key

Signed-off-by: XiaokangQian <xiaokang.qian@arm.com>

library/ssl_tls13_client.c

diff --git a/library/ssl_tls13_client.c b/library/ssl_tls13_client.c
index b23b0c5..0a7edc1 100644
--- a/library/ssl_tls13_client.c
+++ b/library/ssl_tls13_client.c
@@ -783,26 +783,29 @@
 
     identities_len = 6 + psk_identity_len;
     l_binders_len = 1 + hash_len;
-    MBEDTLS_SSL_CHK_BUF_PTR( p, end, 4 + 2 + identities_len + 2 + l_binders_len );
 
     MBEDTLS_SSL_DEBUG_MSG( 3,
                  ( "client hello, adding pre_shared_key extension, "
                    "omitting PSK binder list" ) );
 
     /* Extension header */
+    MBEDTLS_SSL_CHK_BUF_PTR( p, end, 8 );
     MBEDTLS_PUT_UINT16_BE( MBEDTLS_TLS_EXT_PRE_SHARED_KEY, p, 0 );
     MBEDTLS_PUT_UINT16_BE( 2 + identities_len + 2 + l_binders_len , p, 2 );
 
     MBEDTLS_PUT_UINT16_BE( identities_len, p, 4 );
     MBEDTLS_PUT_UINT16_BE( psk_identity_len, p, 6 );
     p += 8;
+    MBEDTLS_SSL_CHK_BUF_PTR( p, end, psk_identity_len );
     memcpy( p, psk_identity, psk_identity_len );
     p += psk_identity_len;
 
     /* add obfuscated ticket age */
+    MBEDTLS_SSL_CHK_BUF_PTR( p, end, 4 );
     MBEDTLS_PUT_UINT32_BE( obfuscated_ticket_age, p, 0 );
     p += 4;
 
+    MBEDTLS_SSL_CHK_BUF_PTR( p, end, 2 + l_binders_len );
     *out_len = ( p - buf ) + l_binders_len + 2;
     *binders_len = l_binders_len + 2;