commit c086cce3d3f3c6a1b18c0f4bfab41686532394a6
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Fri Aug 02 14:13:02 2013 +0200
committer Paul Bakker <p.j.bakker@polarssl.org> Wed Aug 14 14:08:05 2013 +0200
tree b9a1aadbd17f4537c4c0afe6118e9764f2ffec46
parent 7cd5924cec939cde5d906d387b8ec04e82b11e26

Don't cache empty session ID nor resumed session

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 7e8ff34..e790277 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -2539,6 +2539,8 @@
 
 void ssl_handshake_wrapup( ssl_context *ssl )
 {
+    int resume = ssl->handshake->resume;
+
     SSL_DEBUG_MSG( 3, ( "=> handshake wrapup" ) );
 
     /*
@@ -2570,9 +2572,13 @@
     /*
      * Add cache entry
      */
-    if( ssl->f_set_cache != NULL )
+    if( ssl->f_set_cache != NULL &&
+        ssl->session->length != 0 &&
+        resume == 0 )
+    {
         if( ssl->f_set_cache( ssl->p_set_cache, ssl->session ) != 0 )
             SSL_DEBUG_MSG( 1, ( "cache did not store session" ) );
+    }
 
     ssl->state++;