commit c1385c104f3db681d083c21e9d6b8a629fe92aa7
author Hanno Becker <hanno.becker@arm.com> Mon Nov 05 12:44:27 2018 +0000
committer Hanno Becker <hanno.becker@arm.com> Wed Nov 21 21:12:58 2018 +0000
tree 43edbd4f834dbd9deeaa66b88a93d64cf4fc05cc
parent 463194d47a8c8eeb4d2c6006dd16d064b2d12fcf

Don't use idiom `if( func() )` but always add explicit value check

library/ssl_srv.c

diff --git a/library/ssl_srv.c b/library/ssl_srv.c
index 54cce0a..4d99f88 100644
--- a/library/ssl_srv.c
+++ b/library/ssl_srv.c
@@ -3869,7 +3869,7 @@
 #if defined(MBEDTLS_USE_PSA_CRYPTO)
         /* For opaque PSKs, we perform the PSK-to-MS derivation atomatically
          * and skip the intermediate PMS. */
-        if( ssl_use_opaque_psk( ssl ) )
+        if( ssl_use_opaque_psk( ssl ) == 1 )
             MBEDTLS_SSL_DEBUG_MSG( 1, ( "skip PMS generation for opaque PSK" ) );
         else
 #endif /* MBEDTLS_USE_PSA_CRYPTO */