commit c8bdf36a728989cab1b81f0dbcd856f75ea4fdda
author Mateusz Starzyk <mateusz.starzyk@mobica.com> Wed Jul 28 15:39:51 2021 +0200
committer Mateusz Starzyk <mateusz.starzyk@mobica.com> Tue Aug 10 13:58:39 2021 +0200
tree ee9fa0502f886d247b506075eccc839c6d544da4
parent 1bda9451ef395c35b99255625fc647287e4ecc8e

Validate tag pointer in ccm function.

Signed-off-by: Mateusz Starzyk <mateusz.starzyk@mobica.com>

library/ccm.c

diff --git a/library/ccm.c b/library/ccm.c
index a14e025..af26de8 100644
--- a/library/ccm.c
+++ b/library/ccm.c
@@ -478,7 +478,8 @@
     ret = mbedtls_ccm_crypt( ctx, 0, 16, ctx->y, ctx->y );
     if( ret != 0 )
         return ret;
-    memcpy( tag, ctx->y, tag_len );
+    if( tag != NULL )
+        memcpy( tag, ctx->y, tag_len );
     mbedtls_ccm_clear_state(ctx);
 
     return( 0 );

tests/suites/test_suite_ccm.function

diff --git a/tests/suites/test_suite_ccm.function b/tests/suites/test_suite_ccm.function
index 25cc49b..21f0699 100644
--- a/tests/suites/test_suite_ccm.function
+++ b/tests/suites/test_suite_ccm.function
@@ -48,10 +48,7 @@
     mbedtls_free( output );
     output = NULL;
 
-    if( tag->len == 0 )
-        ASSERT_ALLOC( output, 16 );
-    else
-        ASSERT_ALLOC( output, tag->len );
+    ASSERT_ALLOC( output, tag->len );
     TEST_EQUAL( 0, mbedtls_ccm_finish( ctx, output, tag->len ) );
     ASSERT_COMPARE( output, tag->len, tag->x, tag->len );
     mbedtls_free( output );