commit ca6440b246cad700d98c597a7315b68eb6be58f1
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Wed Sep 10 12:39:54 2014 +0000
committer Paul Bakker <p.j.bakker@polarssl.org> Tue Oct 21 16:30:31 2014 +0200
tree bffb2ab616b47b6a80f4a7bcd1ced827931fd7ea
parent 624bcb5260182b6e8cf534ad4f0be679770739ac

Small cleanups in parse_finished()

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index 2856c6b..51a0ac7 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -3720,11 +3720,17 @@
     return( 0 );
 }
 
+#if defined(POLARSSL_SSL_PROTO_SSL3)
+#define SSL_MAX_HASH_LEN 36
+#else
+#define SSL_MAX_HASH_LEN 12
+#endif
+
 int ssl_parse_finished( ssl_context *ssl )
 {
     int ret;
     unsigned int hash_len;
-    unsigned char buf[36];
+    unsigned char buf[SSL_MAX_HASH_LEN];
 
     SSL_DEBUG_MSG( 2, ( "=> parse finished" ) );
 
@@ -3738,8 +3744,6 @@
     ssl->transform_in = ssl->transform_negotiate;
     ssl->session_in = ssl->session_negotiate;
 
-    /* Input counter/epoch not used with DTLS right now,
-     * but it doesn't hurt to have this part ready */
 #if defined(POLARSSL_SSL_PROTO_DTLS)
     if( ssl->transport == SSL_TRANSPORT_DATAGRAM )
     {
@@ -3798,8 +3802,13 @@
         return( POLARSSL_ERR_SSL_UNEXPECTED_MESSAGE );
     }
 
-    // TODO TLS/1.2 Hash length is determined by cipher suite (Page 63)
-    hash_len = ( ssl->minor_ver == SSL_MINOR_VERSION_0 ) ? 36 : 12;
+    /* There is currently no ciphersuite using another length with TLS 1.2 */
+#if defined(POLARSSL_SSL_PROTO_SSL3)
+    if( ssl->minor_ver == SSL_MINOR_VERSION_0 )
+        hash_len = 36;
+    else
+#endif
+        hash_len = 12;
 
     if( ssl->in_msg[0] != SSL_HS_FINISHED ||
         ssl->in_hslen  != ssl_hs_hdr_len( ssl ) + hash_len )