commit cadcf4cec6255a03525474c79f3d96f38c88d860
author Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Thu Jul 16 09:23:30 2020 +0200
committer Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com> Fri Jul 24 11:55:29 2020 +0200
tree 852cbca124d92ab040e91046e4a590e76beee9ad
parent 8be9d3b8333b42f7319305bc93950ec0aabda303

Fix memory leak on error path

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index 41643d2..d2e36e1 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -826,7 +826,10 @@
     /* Unblinding value: Vf = random number, invertible mod N */
     do {
         if( count++ > 10 )
-            return( MBEDTLS_ERR_RSA_RNG_FAILED );
+        {
+            ret = MBEDTLS_ERR_RSA_RNG_FAILED;
+            goto cleanup;
+        }
 
         MBEDTLS_MPI_CHK( mbedtls_mpi_fill_random( &ctx->Vf, ctx->len - 1, f_rng, p_rng ) );