commit cb3a742d1d5ddebd4e25a96249af388079f2c1c9
author gabor-mezei-arm <gabor.mezei@arm.com> Wed Aug 19 14:03:06 2020 +0200
committer gabor-mezei-arm <gabor.mezei@arm.com> Wed Sep 09 14:58:28 2020 +0200
tree 6e106222c4fe4c3a661ac727f6e47ae196c2e5f4
parent 77d940170574fc4e347bc9bb363857269686d2bd

Zeroize internal buffers and variables in MD hashes

Zeroising of local buffers and variables which are used for calculations in
mbedtls_internal_md*_process() and mbedtls_internal_ripemd160_process()
functions to erase sensitive data from memory.
Checked all function for possible missing zeroisation in MD.

Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>

library/md2.c

diff --git a/library/md2.c b/library/md2.c
index 293ada3..eb4d0d0 100644
--- a/library/md2.c
+++ b/library/md2.c
@@ -181,6 +181,9 @@
         t  = ctx->cksum[i];
     }
 
+    /* Zeroise variables to clear sensitive data from memory. */
+    mbedtls_zeroize( &t, sizeof( t ) );
+
     return( 0 );
 }
 

library/md4.c

diff --git a/library/md4.c b/library/md4.c
index 6982559..28e81c8 100644
--- a/library/md4.c
+++ b/library/md4.c
@@ -247,6 +247,13 @@
     ctx->state[2] += C;
     ctx->state[3] += D;
 
+    /* Zeroise variables to clear sensitive data from memory. */
+    mbedtls_zeroize( &X, sizeof( X ) );
+    mbedtls_zeroize( &A, sizeof( A ) );
+    mbedtls_zeroize( &B, sizeof( B ) );
+    mbedtls_zeroize( &C, sizeof( C ) );
+    mbedtls_zeroize( &D, sizeof( D ) );
+
     return( 0 );
 }
 

library/md5.c

diff --git a/library/md5.c b/library/md5.c
index 009a013..9c75cae 100644
--- a/library/md5.c
+++ b/library/md5.c
@@ -266,6 +266,13 @@
     ctx->state[2] += C;
     ctx->state[3] += D;
 
+    /* Zeroise variables to clear sensitive data from memory. */
+    mbedtls_zeroize( &X, sizeof( X ) );
+    mbedtls_zeroize( &A, sizeof( A ) );
+    mbedtls_zeroize( &B, sizeof( B ) );
+    mbedtls_zeroize( &C, sizeof( C ) );
+    mbedtls_zeroize( &D, sizeof( D ) );
+
     return( 0 );
 }
 

library/ripemd160.c

diff --git a/library/ripemd160.c b/library/ripemd160.c
index aee1123..f585077 100644
--- a/library/ripemd160.c
+++ b/library/ripemd160.c
@@ -325,6 +325,19 @@
     ctx->state[4] = ctx->state[0] + B + Cp;
     ctx->state[0] = C;
 
+    /* Zeroise variables to clear sensitive data from memory. */
+    mbedtls_zeroize( &A, sizeof( A ) );
+    mbedtls_zeroize( &B, sizeof( B ) );
+    mbedtls_zeroize( &C, sizeof( C ) );
+    mbedtls_zeroize( &D, sizeof( D ) );
+    mbedtls_zeroize( &E, sizeof( E ) );
+    mbedtls_zeroize( &Ap, sizeof( Ap ) );
+    mbedtls_zeroize( &Bp, sizeof( Bp ) );
+    mbedtls_zeroize( &Cp, sizeof( Cp ) );
+    mbedtls_zeroize( &Dp, sizeof( Dp ) );
+    mbedtls_zeroize( &Ep, sizeof( Ep ) );
+    mbedtls_zeroize( &X, sizeof( X ) );
+
     return( 0 );
 }