commit d80b6ed46dcc44cc1c6749712e3a793a9e2c8cc6
author Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com> Thu Dec 02 09:50:55 2021 +0100
committer Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com> Tue Feb 22 13:35:27 2022 +0100
tree 1cf2d8508ea48bb1b55e1e09e3c9b6b10d2d62aa
parent dc8d7d921164e6e7010120b3e984b45cb11e8aae

Use loop instead goto and fix misleading variable name

Signed-off-by: Przemyslaw Stekiel <przemyslaw.stekiel@mobica.com>

library/psa_crypto.c

diff --git a/library/psa_crypto.c b/library/psa_crypto.c
index fdb4d69..9be1a68 100644
--- a/library/psa_crypto.c
+++ b/library/psa_crypto.c
@@ -4860,7 +4860,7 @@
     size_t bits,
     psa_key_derivation_operation_t *operation,
     uint8_t **data,
-    unsigned *error)
+    unsigned *key_out_of_range)
 {
     mbedtls_mpi N;
     mbedtls_mpi k;
@@ -4931,7 +4931,7 @@
      */
     MBEDTLS_MPI_CHK( mbedtls_mpi_sub_int( &diff_N_2, &N, 2) );
     MBEDTLS_MPI_CHK( mbedtls_mpi_grow( &k, diff_N_2.n ) );
-    MBEDTLS_MPI_CHK( mbedtls_mpi_lt_mpi_ct( &diff_N_2, &k, error ) );
+    MBEDTLS_MPI_CHK( mbedtls_mpi_lt_mpi_ct( &diff_N_2, &k, key_out_of_range ) );
 
     /* 5. Output k + 1 as the private key. */
     MBEDTLS_MPI_CHK( mbedtls_mpi_add_int( &k, &k, 1));
@@ -4969,14 +4969,13 @@
         if ( PSA_KEY_TYPE_ECC_GET_FAMILY( slot->attr.type ) != PSA_ECC_FAMILY_MONTGOMERY )
         {
             /* Weierstrass elliptic curve */
-            unsigned key_err = 0;
-gen_ecc_key:
-            status = psa_generate_derived_ecc_key_weierstrass_helper(slot, bits, operation, &data, &key_err);
-            if( status != PSA_SUCCESS )
-                goto exit;
-            /* Key has been created, but it doesn't meet criteria. */
-            if (key_err)
-                goto gen_ecc_key;
+            unsigned key_out_of_range = 0;
+            do
+            {
+                status = psa_generate_derived_ecc_key_weierstrass_helper(slot, bits, operation, &data, &key_out_of_range);
+                if( status != PSA_SUCCESS )
+                    goto exit;
+            } while ( key_out_of_range );
         }
         else
         {