Add issue numbers to TODO comments
In the python script I didn't use the word TODO because pylint doesn't
like that, but morally it's the same.
I removed the comment about "do we need a subset of compat.sh?" because
it turns out that `ssl-opt.sh` is already exercising all the key
exchanges:
% sed -n 's/.*force_ciphersuite=TLS-\([^ ]*\)-WITH.*/\1/p' tests/ssl-opt.sh | sort -u
DHE-PSK
DHE-RSA
ECDH-ECDSA
ECDHE-ECDSA
ECDHE-PSK
ECDHE-RSA
ECJPAKE
PSK
RSA
RSA-PSK
(the only omission is ECDH-RSA which is not of interest here and does
not actually differ from ECDH-ECDSA). So, we don't need a subset of
compat.sh because we're already getting enough testing from ssl-opt.sh
(not to mention test_suite_ssl).
Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
diff --git a/tests/scripts/all.sh b/tests/scripts/all.sh
index 2412c60..fa82733 100755
--- a/tests/scripts/all.sh
+++ b/tests/scripts/all.sh
@@ -2026,7 +2026,7 @@
scripts/config.py unset MBEDTLS_ECDSA_C
fi
# Disable things that depend on it
- # TODO: make these work
+ # TODO: make these work - #6862
scripts/config.py unset MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED
scripts/config.py unset MBEDTLS_KEY_EXCHANGE_ECDH_ECDSA_ENABLED
}
@@ -2074,8 +2074,7 @@
msg "test: MBEDTLS_PSA_CRYPTO_CONFIG with accelerated ECDSA + USE_PSA"
make test
- # TODO: ssl-opt.sh (currently doesn't pass)
- # TODO: is some subset of compat.sh needed?
+ # TODO: ssl-opt.sh (currently doesn't pass) - #6861
}
# Keep in sync with component_test_psa_crypto_config_accel_ecdsa_use_psa.
@@ -2094,7 +2093,7 @@
msg "test: MBEDTLS_PSA_CRYPTO_CONFIG with accelerated ECDSA + USE_PSA"
make test
- # TODO: ssl-opt.sh (when the accel component is ready)
+ # TODO: ssl-opt.sh (when the accel component is ready) - #6861
}
component_test_psa_crypto_config_accel_ecdh () {