commit d959492797aa315d24e768cc61766542289192a7
author Andrzej Kurek <andrzej.kurek@arm.com> Mon Mar 26 04:13:24 2018 -0400
committer Andrzej Kurek <andrzej.kurek@arm.com> Mon Mar 26 04:13:24 2018 -0400
tree d73ea1c3bcb46c5bb4cc3a53f63124ebdfd5cfd3
parent 69d1b293fc8fb7b127b5bf24a80728f6a0eb16be

pk_sign: fix overriding and ignoring return values

programs/pkey/pk_sign.c

diff --git a/programs/pkey/pk_sign.c b/programs/pkey/pk_sign.c
index daf08a9..06ad3ee 100644
--- a/programs/pkey/pk_sign.c
+++ b/programs/pkey/pk_sign.c
@@ -100,8 +100,7 @@
 
     if( ( ret = mbedtls_pk_parse_keyfile( &pk, argv[1], "" ) ) != 0 )
     {
-        ret = 1;
-        mbedtls_printf( " failed\n  ! Could not open '%s'\n", argv[1] );
+        mbedtls_printf( " failed\n  ! Could not parse '%s'\n", argv[1] );
         goto exit;
     }
 
@@ -141,6 +140,7 @@
 
     if( fwrite( buf, 1, olen, f ) != olen )
     {
+        ret = 1;
         mbedtls_printf( "failed\n  ! fwrite failed\n\n" );
         fclose( f );
         goto exit;