commit db9a38c6721435d73196a69541bc67e9ccf61744
author gabor-mezei-arm <gabor.mezei@arm.com> Mon Sep 27 11:28:54 2021 +0200
committer gabor-mezei-arm <gabor.mezei@arm.com> Tue Sep 28 16:16:14 2021 +0200
tree 152aae5afd4a9da776b1932d768d723515b2ad4b
parent 9fa43ce2380f81537dc28adf35cba4edc5d388bf

Move contatnt-time memcmp functions to the contant-time module

Signed-off-by: gabor-mezei-arm <gabor.mezei@arm.com>

library/rsa.c

diff --git a/library/rsa.c b/library/rsa.c
index 9c11037..f1b8489 100644
--- a/library/rsa.c
+++ b/library/rsa.c
@@ -44,6 +44,7 @@
 #include "mbedtls/oid.h"
 #include "mbedtls/platform_util.h"
 #include "mbedtls/error.h"
+#include "constant_time.h"
 
 #include <string.h>
 
@@ -72,22 +73,6 @@
 #define RSA_VALIDATE( cond )                                           \
     MBEDTLS_INTERNAL_VALIDATE( cond )
 
-#if defined(MBEDTLS_PKCS1_V15)
-/* constant-time buffer comparison */
-static inline int mbedtls_safer_memcmp( const void *a, const void *b, size_t n )
-{
-    size_t i;
-    const unsigned char *A = (const unsigned char *) a;
-    const unsigned char *B = (const unsigned char *) b;
-    unsigned char diff = 0;
-
-    for( i = 0; i < n; i++ )
-        diff |= A[i] ^ B[i];
-
-    return( diff );
-}
-#endif /* MBEDTLS_PKCS1_V15 */
-
 int mbedtls_rsa_import( mbedtls_rsa_context *ctx,
                         const mbedtls_mpi *N,
                         const mbedtls_mpi *P, const mbedtls_mpi *Q,