commit dbb6f08c3fe57e84a17c72ac13ad05514dd7c926
author David Horstmann <david.horstmann@arm.com> Wed Nov 02 15:33:31 2022 +0000
committer David Horstmann <david.horstmann@arm.com> Mon Nov 07 14:08:12 2022 +0000
tree 2a4cd8a67cd18344f0d8398111b98705722ee068
parent 79bb19f7022ee71b7dd1befd98de7faa03bf83e6

Eliminate bad_params variable

Signed-off-by: David Horstmann <david.horstmann@arm.com>

library/ssl_cli.c

diff --git a/library/ssl_cli.c b/library/ssl_cli.c
index 4817bd6..41ea83f 100644
--- a/library/ssl_cli.c
+++ b/library/ssl_cli.c
@@ -2694,17 +2694,14 @@
 
     MBEDTLS_SSL_DEBUG_MSG( 2, ( "ECDH curve: %s", curve_info->name ) );
 
-    int bad_params = 0;
 #if defined(MBEDTLS_ECP_C)
     if( mbedtls_ssl_check_curve( ssl, grp_id ) != 0 )
-        bad_params = 1;
+        return( -1 );
 #else
     if( ssl->handshake->ecdh_ctx.grp.nbits < 163 ||
         ssl->handshake->ecdh_ctx.grp.nbits > 521 )
-        bad_params = 1;
-#endif
-    if( bad_params )
         return( -1 );
+#endif
 
     MBEDTLS_SSL_DEBUG_ECDH( 3, &ssl->handshake->ecdh_ctx,
                             MBEDTLS_DEBUG_ECDH_QP );