commit de12823a1895ab87f3bd8865f2a3ef1cd8c79d09
author Gilles Peskine <Gilles.Peskine@arm.com> Mon Feb 25 21:24:27 2019 +0100
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Feb 26 16:37:42 2019 +0100
tree 4b321f56bd7286cd6befe006134b3e3b21470f61
parent fb8c373a150c49df1f39098d10d2e0e49b4a6c2d

check-files.py: readability improvement in permission check

tests/scripts/check-files.py

diff --git a/tests/scripts/check-files.py b/tests/scripts/check-files.py
index bc5b8f5..0bf0120 100755
--- a/tests/scripts/check-files.py
+++ b/tests/scripts/check-files.py
@@ -91,8 +91,9 @@
     heading = "Incorrect permissions:"
 
     def check_file_for_issue(self, filepath):
-        if not (os.access(filepath, os.X_OK) ==
-                filepath.endswith((".sh", ".pl", ".py"))):
+        is_executable = os.access(filepath, os.X_OK)
+        should_be_executable = filepath.endswith((".sh", ".pl", ".py"))
+        if is_executable != should_be_executable:
             self.files_with_issues[filepath] = None