tree 8cd2a8dd48d19ec48a4add80f1f90dac78662923
parent 6ad3fd105cfe446b47dc8f7fc96c054c48eec5a6
author Hanno Becker <hanno.becker@arm.com> 1556952876 +0100
committer Hanno Becker <hanno.becker@arm.com> 1556952876 +0100

Perform CRT writing in-place on the output buffer

The CRT writing routine mbedtls_x509write_crt_der() prepares the TBS
(to-be-signed) part of the CRT in a temporary stack-allocated buffer,
copying it to the actual output buffer at the end of the routine.

This comes at the cost of a very large stack buffer. Moreover, its size
must be hardcoded to an upper bound for the lengths of all CRTs to be
written through the routine. So far, this upper bound was set to 2Kb, which
isn't sufficient some larger certificates, as was reported e.g. in #2631.

This commit fixes this by changing mbedtls_x509write_crt_der() to write
the certificate in-place in the output buffer, thereby avoiding the use
of a statically sized stack buffer for the TBS.

Fixes #2631.