commit e08660e612de78744ba89aad7284d01ed400ae3f
author Manuel Pégourié-Gonnard <mpg@elzevir.fr> Sat Aug 16 11:28:40 2014 +0200
committer Manuel Pégourié-Gonnard <mpg@elzevir.fr> Tue Aug 19 10:34:37 2014 +0200
tree 90bf7aadadec9ab8981e420088f886f07e94ff72
parent 67686c42e6b961124917fc26dd63540d0f472415

Fix ssl_read() and close_notify error handling in programs

programs/ssl/ssl_server2.c

diff --git a/programs/ssl/ssl_server2.c b/programs/ssl/ssl_server2.c
index 9152213..20df781 100644
--- a/programs/ssl/ssl_server2.c
+++ b/programs/ssl/ssl_server2.c
@@ -1514,7 +1514,8 @@
         memset( buf, 0, sizeof( buf ) );
         ret = ssl_read( &ssl, buf, len );
 
-        if( ret == POLARSSL_ERR_NET_WANT_READ || ret == POLARSSL_ERR_NET_WANT_WRITE )
+        if( ret == POLARSSL_ERR_NET_WANT_READ ||
+            ret == POLARSSL_ERR_NET_WANT_WRITE )
             continue;
 
         if( ret <= 0 )
@@ -1523,18 +1524,18 @@
             {
                 case POLARSSL_ERR_SSL_PEER_CLOSE_NOTIFY:
                     printf( " connection was closed gracefully\n" );
-                    break;
+                    goto close_notify;
 
+                case 0:
                 case POLARSSL_ERR_NET_CONN_RESET:
                     printf( " connection was reset by peer\n" );
-                    break;
+                    ret = POLARSSL_ERR_NET_CONN_RESET;
+                    goto reset;
 
                 default:
                     printf( " ssl_read returned -0x%x\n", -ret );
-                    break;
+                    goto close_notify;
             }
-
-            break;
         }
 
         if( ssl_get_bytes_avail( &ssl ) == 0 )
@@ -1658,10 +1659,22 @@
         printf( " ok\n" );
     }
 
+    /*
+     * 8. Close the connection cleanly
+     */
+close_notify:
     printf( "  . Closing the connection..." );
 
     while( ( ret = ssl_close_notify( &ssl ) ) < 0 )
     {
+        printf( " ret = %d (-0x%04X)", ret, -ret );
+        if( ret == POLARSSL_ERR_NET_CONN_RESET )
+        {
+            printf( " connection was reset by peer\n" );
+            ret = 0;
+            goto reset;
+        }
+
         if( ret != POLARSSL_ERR_NET_WANT_READ &&
             ret != POLARSSL_ERR_NET_WANT_WRITE )
         {
@@ -1671,12 +1684,12 @@
     }
 
     printf( " ok\n" );
-
-    ret = 0;
     goto reset;
 
+    /*
+     * Cleanup and exit
+     */
 exit:
-
 #ifdef POLARSSL_ERROR_C
     if( ret != 0 )
     {