commit e36f5b1c11841ce564c652dc574c252de6265c28
author Mateusz Starzyk <mateusz.starzyk@mobica.com> Thu Jul 22 16:43:35 2021 +0200
committer Mateusz Starzyk <mateusz.starzyk@mobica.com> Tue Aug 10 16:54:21 2021 +0200
tree 3c2fa7dbc8d2920e1649fb0a7a066cd95dc388db
parent 200f58c07e5a1a9d16a97428e22d2bea912fffa5

Fix parantheses on return and sizeof statements.

Used script:
```
import re
import sys

for arg in sys.argv[1:]:
    print(arg)
    with open(arg, 'r') as file:
        content = file.read()
        content = re.sub(r"return\s?\((?!.*\).*\()\s*\n?(.*)\n?\);", r"return \1;", \
            content, flags = re.M)
        content = re.sub(r"sizeof ([^\(][a-zA-Z0-9_\[\]]*)", r"sizeof(\1)",\
            content, flags = re.M)
    with open(arg, 'w') as file:
        file.write(content)

```
Executed with:
` find . -regextype posix-egrep -regex ".*\.([hc]|fmt|function)" | xargs -L1 python script.py`

Signed-off-by: Mateusz Starzyk <mateusz.starzyk@mobica.com>

library/memory_buffer_alloc.c

diff --git a/library/memory_buffer_alloc.c b/library/memory_buffer_alloc.c
index 0d5d27d..54377b5 100644
--- a/library/memory_buffer_alloc.c
+++ b/library/memory_buffer_alloc.c
@@ -132,7 +132,7 @@
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: MAGIC1 mismatch\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     if( hdr->magic2 != MAGIC2 )
@@ -140,7 +140,7 @@
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: MAGIC2 mismatch\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     if( hdr->alloc > 1 )
@@ -148,7 +148,7 @@
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: alloc has illegal value\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     if( hdr->prev != NULL && hdr->prev == hdr->next )
@@ -156,7 +156,7 @@
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: prev == next\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     if( hdr->prev_free != NULL && hdr->prev_free == hdr->next_free )
@@ -164,10 +164,10 @@
 #if defined(MBEDTLS_MEMORY_DEBUG)
         mbedtls_fprintf( stderr, "FATAL: prev_free == next_free\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
-    return( 0 );
+    return 0 ;
 }
 
 static int verify_chain( void )
@@ -180,7 +180,7 @@
         mbedtls_fprintf( stderr, "FATAL: verification of first header "
                                   "failed\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     if( heap.first->prev != NULL )
@@ -189,7 +189,7 @@
         mbedtls_fprintf( stderr, "FATAL: verification failed: "
                                   "first->prev != NULL\n" );
 #endif
-        return( 1 );
+        return 1 ;
     }
 
     cur = heap.first->next;
@@ -202,7 +202,7 @@
             mbedtls_fprintf( stderr, "FATAL: verification of header "
                                       "failed\n" );
 #endif
-            return( 1 );
+            return 1 ;
         }
 
         if( cur->prev != prv )
@@ -211,14 +211,14 @@
             mbedtls_fprintf( stderr, "FATAL: verification failed: "
                                       "cur->prev != prv\n" );
 #endif
-            return( 1 );
+            return 1 ;
         }
 
         prv = cur;
         cur = cur->next;
     }
 
-    return( 0 );
+    return 0 ;
 }
 
 static void *buffer_alloc_calloc( size_t n, size_t size )
@@ -233,14 +233,14 @@
 #endif
 
     if( heap.buf == NULL || heap.first == NULL )
-        return( NULL );
+        return NULL ;
 
     original_len = len = n * size;
 
     if( n == 0 || size == 0 || len / n != size )
-        return( NULL );
+        return NULL ;
     else if( len > (size_t)-MBEDTLS_MEMORY_ALIGN_MULTIPLE )
-        return( NULL );
+        return NULL ;
 
     if( len % MBEDTLS_MEMORY_ALIGN_MULTIPLE )
     {
@@ -259,7 +259,7 @@
     }
 
     if( cur == NULL )
-        return( NULL );
+        return NULL ;
 
     if( cur->alloc != 0 )
     {
@@ -311,7 +311,7 @@
         ret = (unsigned char *) cur + sizeof( memory_header );
         memset( ret, 0, original_len );
 
-        return( ret );
+        return ret ;
     }
 
     p = ( (unsigned char *) cur ) + sizeof(memory_header) + len;
@@ -369,7 +369,7 @@
     ret = (unsigned char *) cur + sizeof( memory_header );
     memset( ret, 0, original_len );
 
-    return( ret );
+    return ret ;
 }
 
 static void buffer_alloc_free( void *ptr )
@@ -546,11 +546,11 @@
 {
     void *buf;
     if( mbedtls_mutex_lock( &heap.mutex ) != 0 )
-        return( NULL );
+        return NULL ;
     buf = buffer_alloc_calloc( n, size );
     if( mbedtls_mutex_unlock( &heap.mutex ) )
-        return( NULL );
-    return( buf );
+        return NULL ;
+    return buf ;
 }
 
 static void buffer_alloc_free_mutexed( void *ptr )
@@ -611,12 +611,12 @@
 static int check_pointer( void *p )
 {
     if( p == NULL )
-        return( -1 );
+        return -1 ;
 
     if( (size_t) p % MBEDTLS_MEMORY_ALIGN_MULTIPLE != 0 )
-        return( -1 );
+        return -1 ;
 
-    return( 0 );
+    return 0 ;
 }
 
 static int check_all_free( void )
@@ -628,10 +628,10 @@
         heap.first != heap.first_free ||
         (void *) heap.first != (void *) heap.buf )
     {
-        return( -1 );
+        return -1 ;
     }
 
-    return( 0 );
+    return 0 ;
 }
 
 #define TEST_ASSERT( condition )            \
@@ -737,7 +737,7 @@
 cleanup:
     mbedtls_memory_buffer_alloc_free( );
 
-    return( ret );
+    return ret ;
 }
 #endif /* MBEDTLS_SELF_TEST */