commit e3bcd9a43218c7c961bf42d0d243e351d1009003
author Jaeden Amero <jaeden.amero@arm.com> Fri Aug 10 10:50:03 2018 +0100
committer Jaeden Amero <jaeden.amero@arm.com> Fri Aug 10 10:50:03 2018 +0100
tree 16401e0ac7c02384a85c53de539b60540ea6d4b8
parent 92b04d9c55a7a62ba8c903b02170bae3bb6381e5
parent ba25ffef8730b8958d3ea312e4ad3bcf1cccc66c

Merge remote-tracking branch 'upstream-public/pr/1887' into mbedtls-2.1

ChangeLog

diff --git a/ChangeLog b/ChangeLog
index 3020633..88036e4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -5,6 +5,8 @@
 Bugfix
    * Fixes an issue with MBEDTLS_CHACHAPOLY_C which would not compile if
      MBEDTLS_ARC4_C and MBEDTLS_CIPHER_NULL_CIPHER weren't also defined. #1890
+   * Fix a memory leak in ecp_mul_comb() if ecp_precompute_comb() fails.
+     Fix contributed by Espressif Systems.
 
 = mbed TLS 2.1.14 branch released 2018-07-25
 

library/ecp.c

diff --git a/library/ecp.c b/library/ecp.c
index 5787b9b..16cc45e 100644
--- a/library/ecp.c
+++ b/library/ecp.c
@@ -1390,7 +1390,12 @@
 
 cleanup:
 
-    if( T != NULL && ! p_eq_g )
+    /* There are two cases where T is not stored in grp:
+     * - P != G
+     * - An intermediate operation failed before setting grp->T
+     * In either case, T must be freed.
+     */
+    if( T != NULL && T != grp->T )
     {
         for( i = 0; i < pre_len; i++ )
             mbedtls_ecp_point_free( &T[i] );