commit e3d882ad4ab271bbfe9183371637f76591c1fea6
author Janos Follath <janos.follath@arm.com> Tue Oct 11 10:49:26 2016 +0100
committer Simon Butcher <simon.butcher@arm.com> Tue Oct 11 13:38:36 2016 +0100
tree 1c488d1866f41d7f2bd75ba0375da5504121ce92
parent 851ae29a5d5b409cac0357da6e0a2b8c22e32887

Remove unnecessary flag from CMAC context

library/cmac.c

diff --git a/library/cmac.c b/library/cmac.c
index 8ea0685..62f2a6a 100644
--- a/library/cmac.c
+++ b/library/cmac.c
@@ -235,7 +235,6 @@
     ctx->cmac_ctx = cmac_ctx;
 
     mbedtls_zeroize( cmac_ctx->state, sizeof( cmac_ctx->state ) );
-    cmac_ctx->padding_flag = 1;
 
     return 0;
 }
@@ -292,8 +291,6 @@
 
         ilen -= block_size;
         input += block_size;
-
-        cmac_ctx->padding_flag = 0;
     }
 
     /* If there is data left over that wasn't aligned to a block */
@@ -303,11 +300,6 @@
                 input,
                 ilen );
         cmac_ctx->unprocessed_len += ilen;
-
-        if( ilen % block_size > 0 )
-            cmac_ctx->padding_flag = 1;
-        else
-            cmac_ctx->padding_flag = 0;
     }
 
 exit:
@@ -340,7 +332,7 @@
     last_block = cmac_ctx->unprocessed_block;
 
     /* Calculate last block */
-    if( cmac_ctx->padding_flag && cmac_ctx->unprocessed_len < block_size )
+    if( cmac_ctx->unprocessed_len < block_size )
     {
         cmac_pad( M_last, block_size, last_block, cmac_ctx->unprocessed_len );
         cmac_xor_block( M_last, M_last, K2, block_size );
@@ -367,7 +359,6 @@
     mbedtls_zeroize( K1, sizeof( K1 ) );
     mbedtls_zeroize( K2, sizeof( K2 ) );
 
-    cmac_ctx->padding_flag = 1;
     cmac_ctx->unprocessed_len = 0;
     mbedtls_zeroize( cmac_ctx->unprocessed_block,
                      sizeof( cmac_ctx->unprocessed_block ) );
@@ -391,7 +382,6 @@
                      sizeof( cmac_ctx->unprocessed_block ) );
     mbedtls_zeroize( cmac_ctx->state,
                      sizeof( cmac_ctx->state ) );
-    cmac_ctx->padding_flag = 1;
 
     return( 0 );
 }