commit e5702489f503f1fc26debc846cb3f4c0ab0b5b66
author Gilles Peskine <Gilles.Peskine@arm.com> Fri Jun 11 21:59:08 2021 +0200
committer Gilles Peskine <Gilles.Peskine@arm.com> Tue Jun 15 00:14:28 2021 +0200
tree 6c01de4fee0d751fa269fb8aa02fdcbbb145174f
parent cadd3d860ee5fba1e380200d2866f75843fc3579

mbedtls_dhm_get_value parameter order: context first, output last

mbedtls_dhm_get_value can be seen as either a copy function or a getter
function. Given the name and the semantics, it's more of a getter, even if
it "gets" by doing a copy. Therefore, put the context first, and the
selector next, leaving the output for last.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

library/ssl_tls.c

diff --git a/library/ssl_tls.c b/library/ssl_tls.c
index bef6864..560597d 100644
--- a/library/ssl_tls.c
+++ b/library/ssl_tls.c
@@ -3871,10 +3871,10 @@
 {
     int ret = MBEDTLS_ERR_ERROR_CORRUPTION_DETECTED;
 
-    if( ( ret = mbedtls_dhm_get_value( &conf->dhm_P, dhm_ctx,
-                                       MBEDTLS_DHM_PARAM_P ) ) != 0 ||
-        ( ret = mbedtls_dhm_get_value( &conf->dhm_G, dhm_ctx,
-                                       MBEDTLS_DHM_PARAM_G ) ) != 0 )
+    if( ( ret = mbedtls_dhm_get_value( dhm_ctx, MBEDTLS_DHM_PARAM_P,
+                                       &conf->dhm_P ) ) != 0 ||
+        ( ret = mbedtls_dhm_get_value( dhm_ctx, MBEDTLS_DHM_PARAM_G,
+                                       &conf->dhm_G ) ) != 0 )
     {
         mbedtls_mpi_free( &conf->dhm_P );
         mbedtls_mpi_free( &conf->dhm_G );