commit e65428ed3dc07f284262da52d77eb72231b012c2
author Solar Designer <solar@openwall.com> Sun Dec 08 18:55:53 2024 +0100
committer Solar Designer <solar@openwall.com> Fri Dec 13 02:10:01 2024 +0100
tree 45457615b1ecc9c9227428401bb17064636073fb
parent 98910a143790aec0c09a1e86b32704af285eb89e

Specify previously missed XMM register clobbers in AES-NI asm blocks

Noticed by Gilles Peskine

Co-authored-by: Gilles Peskine <gilles.peskine@arm.com>
Signed-off-by: Solar Designer <solar@openwall.com>

library/aesni.c

diff --git a/library/aesni.c b/library/aesni.c
index 69fe9e5..4fc1cb9 100644
--- a/library/aesni.c
+++ b/library/aesni.c
@@ -679,7 +679,7 @@
          AESKEYGENA(xmm0_xmm1, "0x36")      "call 1b \n\t"
          :
          : "r" (rk), "r" (key)
-         : "memory", "cc", "0");
+         : "memory", "cc", "xmm0", "xmm1", "0");
 }
 
 /*
@@ -737,7 +737,7 @@
 
          :
          : "r" (rk), "r" (key)
-         : "memory", "cc", "0");
+         : "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
 }
 #endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */
 
@@ -805,7 +805,7 @@
          AESKEYGENA(xmm1_xmm2, "0x40")      "call 1b \n\t"
          :
          : "r" (rk), "r" (key)
-         : "memory", "cc", "0");
+         : "memory", "cc", "xmm0", "xmm1", "xmm2", "0");
 }
 #endif /* !MBEDTLS_AES_ONLY_128_BIT_KEY_LENGTH */